You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Curently the app_config module depends on essentially all other modules because it imports the types and classes for everything and combines everything into one place. Then the single huge Config class is pulled into the server and started. This is nice but it means that any module that imports from the app_config module depends on all other modules. Which is not nice and is putting us on the road to having circular dependencies.
We can improve this by:
having each component own its own config
move the large Config class to bases.data_api or just fully remove it and make each server compose its own large config object at startup
with the above two changes the app_config module is essentially non-existent or very little is left in there
With this we do not have the case where if you import anything from the app_config module then you have to also import a bunch of fully unrelated stuff due to the fact that app config depends on essentially ALL other modules.
The text was updated successfully, but these errors were encountered:
move the large Config class to bases.data_api or just fully remove it and make each server compose its own large config object at startup
If you do this, then repository classes will be instantiated multiple times, one for each blueprint which requires the class.
The app_config module depends on all other modules because it does dependency management. If you import any class from it, it should be a type-only import to not create any cycle.
There is the possibility of having each module own its config, and then to handle dependencies from other modules, a type-only import must be used.
Curently the
app_config
module depends on essentially all other modules because it imports the types and classes for everything and combines everything into one place. Then the single hugeConfig
class is pulled into the server and started. This is nice but it means that any module that imports from the app_config module depends on all other modules. Which is not nice and is putting us on the road to having circular dependencies.We can improve this by:
Config
class tobases.data_api
or just fully remove it and make each server compose its own large config object at startupapp_config
module is essentially non-existent or very little is left in thereWith this we do not have the case where if you import anything from the
app_config
module then you have to also import a bunch of fully unrelated stuff due to the fact that app config depends on essentially ALL other modules.The text was updated successfully, but these errors were encountered: