Unhandled exception about OAuthClients being expired

[olevski]

If I am not mistaken the oauth clients being expired is something we expect. From time to time. But there are events in Sentry that seems to indicate that we do not handle such cases. I think that probably in this case we dont want to responde with a 500 but something else - like 404 or 401.

Here is the link to the sentry error: https://sentry.dev.renku.ch/organizations/sentry/issues/9154/events/890cc87a12fb4a788a2e7f7f7e36b4fc/

Here is the trace and error:

/app/env/lib/python3.12/site-packages/renku_data_services/repositories/db.py in _get_repository_authenticated at line 123

            adapter = get_provider_adapter(connection.client)
            request_url = adapter.get_repository_api_url(repository_url)
            headers = adapter.api_common_headers or dict()
            if etag:
                headers["If-None-Match"] = etag
            response = await oauth2_client.get(request_url, headers=headers)

The error is:

OAuthError
invalid_grant: The provided authorization grant is invalid, expired, revoked, does not match the redirection URI used in the authorization request, or was issued to another client.

[leafty]

This is not an expected error. The tokens should be renewed when expired. This error comes from the OAuth2Client not being able to issue a token renewal request.