Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check httpx raise_for_status calls #698

Open
olevski opened this issue Mar 3, 2025 · 0 comments
Open

Check httpx raise_for_status calls #698

olevski opened this issue Mar 3, 2025 · 0 comments

Comments

@olevski
Copy link
Member

olevski commented Mar 3, 2025

The raise_for_status call from httpx is called several times in our code. It fails when the status is anything not equal to 2xx.

And we do not handle these exceptions in our centralized exception handler. So that means that these calls result in 500 status codes for the API. But perhaps some of them should be 404s or 401s. So it would be good to change these.

Also if we want to keep using this is may be a good idea to add a handler for this exception in the centralized error handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant