Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision in requirements #1502

Closed
DavHau opened this issue Aug 26, 2020 · 2 comments · Fixed by #1525
Closed

Collision in requirements #1502

DavHau opened this issue Aug 26, 2020 · 2 comments · Fixed by #1525
Assignees

Comments

@DavHau
Copy link

DavHau commented Aug 26, 2020

The the requirements specified by the wheel distribution of renku 0.11.1 result in a python environment with colliding packages gitdb and gitdb2. See here: DavHau/mach-nix#101

The python package manager of your choice might ignore this collision, but that doesn't solve the issue itself
There are two different libraries with the same import path.
Therefore one doesn't really know which package is being used during runtime.

The problematic part of the dependency tree is:

renku - 0.11.1 - wheel
│
├── gitdb2 - 3.0.1 - wheel
├── gitpython - 3.1.0 - wheel
│   └── gitdb - 4.0.5 - wheel
│       └── smmap - 3.0.4 - wheel

The problem can either be fixed by removing the requirement gitdb2 or my patching gitpython upstream to also require gitdb2 instead of gitdb

@rokroskar
Copy link
Member

Thanks for opening the issue @DavHau! I am transferring it to the renku-python repo, where it can receive the proper attention.

@rokroskar rokroskar transferred this issue from SwissDataScienceCenter/renku Sep 2, 2020
@Panaetius
Copy link
Member

Nice catch! gitdb2 is a direct mirror of gitdb, since the devs had lost access to the gitdb package for a while ( gitpython-developers/gitdb#59 ). Since they have access again since ~2017, we should switch back to gitdb in the renku-python requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants