Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature_name not actually converted to feature_id across all package #4

Open
barbarazpc opened this issue Sep 19, 2023 · 0 comments
Open

feature_name not actually converted to feature_id across all package #4

barbarazpc opened this issue Sep 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@barbarazpc
Copy link
Collaborator

molecules(me, assayName = "detected", flatten = TRUE) shows that feature_name still ends up being the column name. But it should be feature_id. This is apparent when using the ggplot_me functions:
-byFillargument still needs feature_names. Should be changed to feature_id

Also:

  • geom_polygon_me should accept assay names different than "cell" as the default, or at least warn user.
@barbarazpc barbarazpc added the bug Something isn't working label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barbarazpc