Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockstore/bincode de/serialization refactoring #216

Open
dnut opened this issue Aug 9, 2024 · 0 comments
Open

blockstore/bincode de/serialization refactoring #216

dnut opened this issue Aug 9, 2024 · 0 comments

Comments

@dnut
Copy link
Contributor

dnut commented Aug 9, 2024

Address these comments from the blockstore db pr:

#194 (comment)
any reason we have this as a struct other than to group together a few bincode helper functions? - would probably be better to just have the functions (and no wrapper struct) -- also, serializeAlloc is the same as bincode.writeAlloc


#194 (comment)
should just call bincode.readFromSlice instead of this wrapper function

...

if you would want to rename bincode.readFromSlice to bincode.deserialize we can always type declare it as an import to be called deserialize in the files it is used (pub const deserialize = bincode.readFromSlice) and add a TODO: remove after renaming bincode methods throughout codebase


#194 (comment)
this can probably be a bincode helper function - could see it being useful elsewhere too


My thought is basically that I like the isolated namespace for organization, imports, and as a lightweight abstraction, but it's not really that important. This code is about to change soon for other reasons anyway, so we can revisit it at that point.

@dnut dnut changed the title blockstore/bincode deserialization refactoring blockstore/bincode de/serialization refactoring Aug 9, 2024
@dnut dnut added this to Sig Oct 11, 2024
@dnut dnut moved this to 📋 Backlog in Sig Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant