Error when building Boost on docker

[paskino]

On docker, with miniconda we install whatever latest version of python miniconda comes with. I tried to fix it at 3.9 and got a build error regarding system Boost and python which are incompatible. In fact, system python on ubuntu22.04 is 3.10.

So I set USE_SYSTEM_Boost=OFF and I got several build errors on Gadgetron, of this type:

/opt/SIRF-SuperBuild/sources/Gadgetron/core/io/from_string.h:19:24: error: ‘numeric_limits’ is not a member of ‘std’
   19 |         if (tmp < std::numeric_limits<T>::min() || tmp > std::numeric_limits<T>::max())
      |                        ^~~~~~~~~~~~~~

[KrisThielemans]

I don't know what errors you saw with system Boost and python incompatibility. I would only expect that when you install boost.python. Indeed, I see you did that in #718. The question is why though. We don't use it. Gadgetron can, but in the good old days, we disabled that in our build, as we don't use Python gadgets.

The error that you quote has nothing to do with boost itself, but other stuff. That one is likely caused by a Gadgetron bug.of missing headers. I've created gadgetron/gadgetron#1207 As from_string.h includes a boost header, it's possible that that header includes <limits> in some boost versions but not others.

By the way, we install a rather old Boost version when building Gadgetron.

SIRF-SuperBuild/version_config.cmake

Lines 34 to 36 in 810a98c

	if (BUILD_GADGETRON)
	# https://github.com/gadgetron/gadgetron/blob/12ffc43debb9bad2e170713006d29dea78d966bf/CMakeLists.txt#L205-L209
	set(Boost_REQUIRED_VERSION 1.71.0)

That' s probably a left-over. (Gadgetron's CMake requires boost 1.71.0, but that doesn't mean we should install that version I guess).

[paskino]

I had to add the build of boost python.
https://github.com/paskino/SIRF-SuperBuild/blob/9f0636cf67a56f3a4eea228340dca7f64281a553/SuperBuild/External_Boost_configureboost.cmake#L27

[KrisThielemans]

I had to add the build of boost python.

I've raised gadgetron/gadgetron#1211. Maybe you can add more detail if there was anything else, or even do a PR...

[paskino]

Should be fixed by gadgetron/gadgetron@9274e7f