Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple requirements*.*/environment.* #834

Open
KrisThielemans opened this issue Aug 13, 2023 · 0 comments
Open

multiple requirements*.*/environment.* #834

KrisThielemans opened this issue Aug 13, 2023 · 0 comments
Assignees

Comments

@KrisThielemans
Copy link
Member

At present, we have multiple occurences of installation of Python dependencies:

Docker (uses mamba):

VM (uses system Python):

Note that our GitHub Actions workflow uses user_python-ubuntu.sh with system Python (to somewhat mimic the VM) and hence uses docker/requirements.txt, and nothing from SIRF-Exercises.

Moreover, these files are not always consistent regarding what they require, including version restrictions (e.g. docker/requirement.yml still restricts SciPy to 1.7.3.

Some of this is because SIRF-Exercises/environment.yml and requirements.txt are relatively recent. A relevant discussion is in #493.

A temporary solution which doesn't break too many things could be:

  • keep docker/requirements-service.* in docker/user_service-ubuntu.sh and VirtualBox/INSTALL_python_packages.sh
  • remove docker/requirements.yml and its usage
  • keep docker/requirements.txt and its usage in docker/user_service-ubuntu.sh

but it doesn't seem very logical. Easiest seems to remove the SciPy version restriction, which will at least prevent some surprising dependency versions.

I also notice that SIRF-Exercises/requirements.txt installs jupyterlab, but SIRF-Exercises/environment.yml does not. Not sure what best practice for that is, but note that the VM uses requirements.txt to install jupyterlab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants