From f99328602f18b790234c82cc21d2bb9df5fe59a0 Mon Sep 17 00:00:00 2001
From: MrX-SNX <max@cc.snxdao.io>
Date: Sun, 1 Sep 2024 20:41:00 +0100
Subject: [PATCH] ref: removed unused pfp (#430)

* ref: removed unused pfp

* ref: check if address is defined
---
 .../components/CouncilTabs/CouncilTabs.tsx    |  2 -
 .../components/CouncilUser/CouncilUser.tsx    |  2 +-
 .../EditNominationConfirmation.tsx            |  2 +-
 .../EditNomination/EditNominationSelect.tsx   |  2 +-
 .../components/NominateSelf/NominateSelf.tsx  |  4 +-
 .../components/UserListItem/UserListItem.tsx  |  8 +-
 .../ProfilePicture/ProfilePicture.tsx         | 87 +++++++------------
 .../UserProfileCard/UserProfileDetails.tsx    |  2 +-
 .../UserProfileEditPreview.tsx                |  2 +-
 .../UserTableView/UserTableView.tsx           |  1 -
 10 files changed, 37 insertions(+), 75 deletions(-)

diff --git a/governance/ui/src/components/CouncilTabs/CouncilTabs.tsx b/governance/ui/src/components/CouncilTabs/CouncilTabs.tsx
index 4f8b7823b..7cf3da698 100644
--- a/governance/ui/src/components/CouncilTabs/CouncilTabs.tsx
+++ b/governance/ui/src/components/CouncilTabs/CouncilTabs.tsx
@@ -162,7 +162,6 @@ export default function CouncilTabs({ activeCouncil }: { activeCouncil: CouncilS
                   </Text>
                   {councilPeriod === '2' && utils.isAddress(voteAddressState) ? (
                     <ProfilePicture
-                      imageSrc={userInformation[index].userInformation?.pfpUrl}
                       address={userInformation[index].userInformation?.address}
                       size={9}
                       newVoteCast={voteAddressState}
@@ -173,7 +172,6 @@ export default function CouncilTabs({ activeCouncil }: { activeCouncil: CouncilS
                       <>
                         {userInformation[index].userInformation?.address && (
                           <ProfilePicture
-                            imageSrc={userInformation[index].userInformation?.pfpUrl}
                             address={userInformation[index].userInformation?.address}
                             size={9}
                             newVoteCast={voteAddressState}
diff --git a/governance/ui/src/components/CouncilUser/CouncilUser.tsx b/governance/ui/src/components/CouncilUser/CouncilUser.tsx
index a8e6ca33f..142318362 100644
--- a/governance/ui/src/components/CouncilUser/CouncilUser.tsx
+++ b/governance/ui/src/components/CouncilUser/CouncilUser.tsx
@@ -37,7 +37,7 @@ export default function CouncilUser({
           <Image src={council.image} w="8" h="8" />
         </Flex>
         {user ? (
-          <ProfilePicture size={9} imageSrc={user?.pfpUrl} address={user?.address} ml="-3" />
+          <ProfilePicture size={9} address={user?.address} ml="-3" />
         ) : (
           <Box
             borderRadius="50%"
diff --git a/governance/ui/src/components/EditNomination/EditNominationConfirmation.tsx b/governance/ui/src/components/EditNomination/EditNominationConfirmation.tsx
index aec8e73e5..b0f9d2350 100644
--- a/governance/ui/src/components/EditNomination/EditNominationConfirmation.tsx
+++ b/governance/ui/src/components/EditNomination/EditNominationConfirmation.tsx
@@ -52,7 +52,7 @@ export default function EditNominationConfirmation({
         mt="3"
         mb="3"
       >
-        <ProfilePicture imageSrc={user?.pfpUrl} address={user?.address} size={10} />
+        <ProfilePicture address={user?.address} size={10} />
         <Flex flexDirection="column" ml="2">
           <Text
             fontSize="sm"
diff --git a/governance/ui/src/components/EditNomination/EditNominationSelect.tsx b/governance/ui/src/components/EditNomination/EditNominationSelect.tsx
index 1d5f4e913..d2394d374 100644
--- a/governance/ui/src/components/EditNomination/EditNominationSelect.tsx
+++ b/governance/ui/src/components/EditNomination/EditNominationSelect.tsx
@@ -36,7 +36,7 @@ export default function EditNominationSelect({
         mt="3"
         mb="3"
       >
-        <ProfilePicture imageSrc={user?.pfpUrl} address={user?.address} size={10} />
+        <ProfilePicture address={user?.address} size={10} />
         <Flex flexDirection="column" ml="2">
           <Text
             fontSize="sm"
diff --git a/governance/ui/src/components/NominateSelf/NominateSelf.tsx b/governance/ui/src/components/NominateSelf/NominateSelf.tsx
index 54b1cdbc2..82026d1fa 100644
--- a/governance/ui/src/components/NominateSelf/NominateSelf.tsx
+++ b/governance/ui/src/components/NominateSelf/NominateSelf.tsx
@@ -126,7 +126,7 @@ export default function NominateSelf({ activeCouncil, ...props }: NominateSelfPr
             alignItems="center"
             mb="12"
           >
-            <ProfilePicture imageSrc={data?.pfpUrl} address={activeWallet?.address} size={10} />
+            <ProfilePicture address={activeWallet?.address} size={10} />
             <Flex ml="2" flexDir="column">
               <Text
                 fontWeight={700}
@@ -212,7 +212,7 @@ export default function NominateSelf({ activeCouncil, ...props }: NominateSelfPr
             mb="12"
             alignItems="center"
           >
-            <ProfilePicture imageSrc={data?.pfpUrl} address={data?.address} size={10} />
+            <ProfilePicture address={data?.address} size={10} />
             <Flex ml="2" flexDir="column">
               <Text
                 fontWeight={700}
diff --git a/governance/ui/src/components/UserListItem/UserListItem.tsx b/governance/ui/src/components/UserListItem/UserListItem.tsx
index c787060a9..ba5084f46 100644
--- a/governance/ui/src/components/UserListItem/UserListItem.tsx
+++ b/governance/ui/src/components/UserListItem/UserListItem.tsx
@@ -44,13 +44,7 @@ export default function UserListItem({
       {...props}
     >
       <Flex alignItems="center">
-        <ProfilePicture
-          imageSrc={user?.pfpUrl}
-          address={address}
-          ImageProps={{ w: '8', h: '8' }}
-          size={9}
-          mr="0"
-        />
+        <ProfilePicture address={address} ImageProps={{ w: '8', h: '8' }} size={9} mr="0" />
         <Text
           fontWeight="bold"
           fontSize="14px"
diff --git a/governance/ui/src/components/UserProfileCard/ProfilePicture/ProfilePicture.tsx b/governance/ui/src/components/UserProfileCard/ProfilePicture/ProfilePicture.tsx
index 4fee161a2..453c95664 100644
--- a/governance/ui/src/components/UserProfileCard/ProfilePicture/ProfilePicture.tsx
+++ b/governance/ui/src/components/UserProfileCard/ProfilePicture/ProfilePicture.tsx
@@ -1,8 +1,7 @@
-import { Box, Image, ImageProps } from '@chakra-ui/react';
+import { Box, ImageProps } from '@chakra-ui/react';
 import Blockies from 'react-blockies';
 
 interface ProfilePictureInterface {
-  imageSrc?: string;
   address?: string;
   ImageProps?: ImageProps;
   size?: number;
@@ -13,67 +12,39 @@ interface ProfilePictureInterface {
 }
 
 export const ProfilePicture = ({
-  imageSrc,
   address,
-  ImageProps,
   size = 14,
   mr,
   ml,
   newVoteCast,
   isCouncilTabs,
 }: ProfilePictureInterface) => {
-  return (
-    <>
-      {imageSrc ? (
-        <Box zIndex={10} position="relative">
-          {!!newVoteCast && (
-            <Box
-              bg="lightgray"
-              opacity={0.5}
-              h={size}
-              w={size}
-              borderRadius="100%"
-              position="absolute"
-              zIndex={11}
-            />
-          )}
-          <Image
-            borderRadius="full"
-            src={imageSrc}
-            w={size}
-            h={size}
-            mr={mr}
-            ml={ml}
-            {...ImageProps}
-          />
-        </Box>
-      ) : (
-        (address || !!newVoteCast) && (
-          <Box
-            mr={mr}
-            ml={ml}
-            borderRadius="100%"
-            sx={{
-              '.fully-rounded': {
-                borderRadius: '99999px',
-              },
-            }}
-            filter={isCouncilTabs ? 'grayscale(1)' : ''}
-            zIndex={10}
-            position="relative"
-            data-cy={`user-blockies-council-tabs-${address || newVoteCast}`}
-          >
-            {!!newVoteCast && (
-              <Box h={size} w={size} borderRadius="100%" position="absolute" zIndex={11} />
-            )}
-            <Blockies
-              size={size}
-              seed={address?.toLowerCase() || newVoteCast?.toLowerCase() || ''}
-              className="fully-rounded"
-            />
-          </Box>
-        )
-      )}
-    </>
-  );
+  if (address || newVoteCast) {
+    return (
+      <Box
+        mr={mr}
+        ml={ml}
+        borderRadius="100%"
+        sx={{
+          '.fully-rounded': {
+            borderRadius: '99999px',
+          },
+        }}
+        filter={isCouncilTabs ? 'grayscale(1)' : ''}
+        zIndex={10}
+        position="relative"
+        data-cy={`user-blockies-council-tabs-${address || newVoteCast}`}
+      >
+        {!!newVoteCast && (
+          <Box h={size} w={size} borderRadius="100%" position="absolute" zIndex={11} />
+        )}
+        <Blockies
+          size={size}
+          seed={address?.toLowerCase() || newVoteCast?.toLowerCase() || ''}
+          className="fully-rounded"
+        />
+      </Box>
+    );
+  }
+  return null;
 };
diff --git a/governance/ui/src/components/UserProfileCard/UserProfileDetails.tsx b/governance/ui/src/components/UserProfileCard/UserProfileDetails.tsx
index 6e578455d..428402d90 100644
--- a/governance/ui/src/components/UserProfileCard/UserProfileDetails.tsx
+++ b/governance/ui/src/components/UserProfileCard/UserProfileDetails.tsx
@@ -125,7 +125,7 @@ export const UserProfileDetails = ({
             _hover={{}}
           />
         )}
-        <ProfilePicture imageSrc={userData?.pfpUrl} address={userData?.address} />
+        <ProfilePicture address={userData?.address} />
         <Flex flexDir="column" w="100%" ml="2">
           <Flex justifyContent="space-between">
             <Text
diff --git a/governance/ui/src/components/UserProfileForm/UserProfileEditPreview.tsx b/governance/ui/src/components/UserProfileForm/UserProfileEditPreview.tsx
index 9c7dda717..30773dc91 100644
--- a/governance/ui/src/components/UserProfileForm/UserProfileEditPreview.tsx
+++ b/governance/ui/src/components/UserProfileForm/UserProfileEditPreview.tsx
@@ -75,7 +75,7 @@ export default function UserProfileEditPreview({
       mb="24"
     >
       <Flex>
-        <ProfilePicture imageSrc={userData?.pfpUrl} address={userData?.address || activeWallet} />
+        <ProfilePicture address={userData?.address || activeWallet} />
         <Flex flexDir="column" w="100%" justifyContent="center" ml="2">
           <Text
             fontSize="16px"
diff --git a/governance/ui/src/components/UserTableView/UserTableView.tsx b/governance/ui/src/components/UserTableView/UserTableView.tsx
index 961b8e134..ca49ccd91 100644
--- a/governance/ui/src/components/UserTableView/UserTableView.tsx
+++ b/governance/ui/src/components/UserTableView/UserTableView.tsx
@@ -97,7 +97,6 @@ export default function UserTableView({
       >
         <Flex gap="2" alignItems="center">
           <ProfilePicture
-            imageSrc={user?.pfpUrl}
             address={user?.address}
             size={9}
             mr="0"