Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to search for all rooms #217

Open
2 tasks
mschwrdtnr opened this issue Sep 6, 2019 · 10 comments
Open
2 tasks

Possibility to search for all rooms #217

mschwrdtnr opened this issue Sep 6, 2019 · 10 comments
Labels
feature An enhancement or a new functionality feature. prio-3 Priority 3

Comments

@mschwrdtnr
Copy link
Member

mschwrdtnr commented Sep 6, 2019

Is your feature request related to a problem? Please describe.
If you search for a room where no one sits you can't find him.

Describe the solution you'd like
If you search in the searchbar for something you will get room suggestions and auto complete stuff.

  • You type in 223 -> you will get a suggestion like Material-autocomplete (Room Icon - Room 223) -> if you click on the suggestion you will redirect to the belonging room page.

Important things:

Google example:
image

@mschwrdtnr mschwrdtnr added the feature An enhancement or a new functionality feature. label Sep 6, 2019
@mschwrdtnr mschwrdtnr self-assigned this Sep 12, 2019
@mschwrdtnr mschwrdtnr removed their assignment Sep 27, 2019
@mschwrdtnr mschwrdtnr added the prio-3 Priority 3 label Oct 17, 2019
@mschwrdtnr mschwrdtnr pinned this issue Oct 22, 2019
@mschwrdtnr
Copy link
Member Author

@Zeroks77 will solve this issue. If you @T-Systems-MMS/phonebook-developers have any ideas or things to say to this issue please do it this week! <3

@mschwrdtnr mschwrdtnr added this to the Big new release milestone Nov 6, 2019
@DanielHabenicht
Copy link
Collaborator

DanielHabenicht commented Nov 6, 2019

I would specify an out of scope sentence: do not show the results in the table (only show them as suggestion)

I think we should speak about how the search should be structured before implementing anything.

Because it might be a little bit overwhelming with future features that are all located in the search bar.
What I mean is:

Where are we searching for people, org units and locations? Do we use the same search bar for everything? Should it be site specific? Are the results shown site specific or should we build a shared search result view?
Because in my mind using the suggestion feature is a little bit counterintuitive as I (as a user) would expect that filter tags are suggested as I type.

@Zeroks77
Copy link
Collaborator

Zeroks77 commented Nov 7, 2019

As @paule96 just told me, we should use the specific sections.

In the room section we only browse for rooms and usually we browse for people and so on.

@mschwrdtnr
Copy link
Member Author

If you want specific search bars: We need to visualize that the searchbar have changed on different sites.

A way with one searchbar can be:

  • One searchbar for everything (like now)

  • Small Settings Button on the right side with options to change the search results

    • Settings: checkboxes for different options (All checked options will be suggested)
      -> Rooms, OrgUnits, People, Location,... (but not tooooo much)
  • Another way: The options People, Rooms, OrgUnit stand under the searchbar with chips and can be toggled on and off.

  • The named options should not affect the search results but the suggestions.

While i wrote i also can image that the site specific search can be cool:

  • You are on the rooms page: Searchbar is changing to "Search for a specific room"
  • You are on the organi page: Searchbar is changing to "Search for a OrgUnit or a Person in the Organigram"
  • A small information that you only search for ... and a link to redirect to the "Main Search"

@Zeroks77
Copy link
Collaborator

Zeroks77 commented Nov 7, 2019

When I was just talking to a colleague, I simply asked him what he thought was better...

I think when we talk to some other colleagues it becomes clearer, but he was in favour of being able to search for rooms in the room page and would not like to have to edit the search bar via checkboxes or something like that...

@mschwrdtnr
Copy link
Member Author

mschwrdtnr commented Nov 7, 2019

I don't really like the way to just talk to a some people in one department. I also can imagine that the asked people aren't the persons who often use the phonebook and also have more technical expertise than other colleagues in e.g. HR department.

But yes, i also think that the option with one searchbar can a bit too much for the simple users and we should use specific site searchbars.

@DanielHabenicht
Copy link
Collaborator

@Zeroks77 talk to as many as you can. It's always a good idea. Just keep @mschwrdtnr sentence in your mind :)

If we use different search bars the question arises what the dashboard search bar does. ;)

@Zeroks77
Copy link
Collaborator

Zeroks77 commented Nov 7, 2019

but if you consider the dashboard search bar as the "main search bar" for people, it would serve a purpose

@DanielHabenicht
Copy link
Collaborator

That's not what I meant, I meant that it would either search for all (people, room, org) or there should be non, there has to be a switch or it just searches for people. In either way, the search action taken has to be clear to the user.

@Zeroks77
Copy link
Collaborator

Zeroks77 commented Nov 8, 2019

ohhh k ...

this could be very defficult i imagine :/

@Zeroks77 Zeroks77 removed their assignment Dec 3, 2019
@Zeroks77 Zeroks77 unpinned this issue Feb 20, 2020
@mschwrdtnr mschwrdtnr pinned this issue Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature An enhancement or a new functionality feature. prio-3 Priority 3
Projects
None yet
Development

No branches or pull requests

3 participants