Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognizable states in the menu #523

Open
VanLampe opened this issue Mar 11, 2020 · 7 comments
Open

Recognizable states in the menu #523

VanLampe opened this issue Mar 11, 2020 · 7 comments
Labels
bug Something isn't working good first issue Good for newcomers prio-5 Priority 5

Comments

@VanLampe
Copy link
Contributor

VanLampe commented Mar 11, 2020

Is your feature request related to a problem? Please describe.
The PhoneBook currently has no visible appstate, except from the url. For example, if youre on the dashboard page, the Button "dashboard" is still clickable.

Describe the solution you'd like
The current state should be recognizable by the menu and not just by the url.
So if I'm in the dashboard state, the corresponding Button should be disabled and marked as current state (for example bold font or sth. similar).

@VanLampe VanLampe added feature An enhancement or a new functionality feature. prio-5 Priority 5 labels Mar 11, 2020
@DanielHabenicht
Copy link
Collaborator

angular/components#13084

@DanielHabenicht
Copy link
Collaborator

I am against disabling it.

Is everybody ok with bold font? @T-Systems-MMS/phonebook-developers
image
or with background?
image

@friedaxvictoria
Copy link
Contributor

I prefer the bold font.

@mschwrdtnr
Copy link
Member

Sure @DanielHabenicht

@DanielHabenicht
Copy link
Collaborator

DanielHabenicht commented Mar 23, 2020

@mschwrdtnr this was a two fold question that can't be answered by yes or no.

@mschwrdtnr
Copy link
Member

Oh, what about the second one without bold text?

@DanielHabenicht DanielHabenicht added good first issue Good for newcomers bug Something isn't working and removed feature An enhancement or a new functionality feature. labels Mar 26, 2020
@paule96
Copy link
Collaborator

paule96 commented Apr 20, 2020

Maybe we should think more about the design. Ask a few people in the MMS about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers prio-5 Priority 5
Projects
None yet
Development

No branches or pull requests

5 participants