Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the message box for uploading pictures, because we want use the pictures in many systems #770

Open
paule96 opened this issue Dec 1, 2020 · 6 comments
Labels
feature An enhancement or a new functionality feature. good first issue Good for newcomers

Comments

@paule96
Copy link
Collaborator

paule96 commented Dec 1, 2020

We currently have the following dialog, if the user is uploading a picture:

current dialog

This dialog only ask for picture permission for the phonebook service. The problem is here we can't share this pictures with other services. In the feature we want use the pictures in many other systems. To be able to do this, we need a checkbox for every system that is allowed to use this picture. Like this:

sample feature dialog

The information wich application is allowed to use the picture must then be committed to the picture service.

Hint: the picture service isn't public available and must be changed internally.

Sample workflow (thx to @Compufreak345):

  1. First upload picture in a stream. (response is a temporary id, of the file that is stored in a temporary location of the server)
  2. Then you can make a request like that to commit the change of the picture:
{
  "picture": 'picture-id',
   "allowedSystems": [
      "Confluence",
      "Phonebook"
   ]
}

Hint: The server must check the temp-dir of dead images.

Important: Implement this with a feature flag! The we can test this in production.

@paule96 paule96 added the feature An enhancement or a new functionality feature. label Dec 1, 2020
@paule96
Copy link
Collaborator Author

paule96 commented Dec 1, 2020

cc @DanielHabenicht @mschwrdtnr

@paule96 paule96 added the good first issue Good for newcomers label Dec 1, 2020
@DanielHabenicht
Copy link
Collaborator

also the picture server needs to have one more endpoint:
something like:

# To get the services the picture is shared with (and which of them the user has allowed) 
GET http://picture-service.de/api/<user>/services
{
   "allowedSystems": [
      {
        "id": "5hs9foeu",
        "name": "Confluence",
        "share-image": true,
      },
      {
        "id": "98dfg07f",
        "name": "Phonebook",
        "share-image": true,
      }
   ]
}

Maybe also an endpoint to get the legal text dynamically.

@mschwrdtnr
Copy link
Member

Link to the gone feature flag integration: https://gist.github.com/mschwrdtnr/69d09c6d69c4c3d7880462bcafe92c8f

@DanielHabenicht
Copy link
Collaborator

Why is it gone?

@mschwrdtnr
Copy link
Member

Why is it gone?

Only the switch on the settings page is gone. Idk why, but we talked about 😄

@paule96
Copy link
Collaborator Author

paule96 commented Dec 10, 2020

The backend Work is here: #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature An enhancement or a new functionality feature. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants