Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image does not reload in chrome #792

Open
DanielHabenicht opened this issue Jan 6, 2021 · 0 comments
Open

Image does not reload in chrome #792

DanielHabenicht opened this issue Jan 6, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@DanielHabenicht
Copy link
Collaborator

DanielHabenicht commented Jan 6, 2021

Describe the bug:

Somebody, cough @Zeroks77 cough implemented a great april pun but neglected that the random variable is important :)
Nevermind, I read the if statement the other way around, so something does not seem to work.

To Reproduce:

  1. Upload a picture in chrome
  2. The picture does not change because it still gets cached.

Expected behavior:

Additional context:

this.RANDOM = Math.random().toString();
this.updateImageUrl();

The random reload feature is disabled because it only gets enabled with the feature flag on.
Either we should find a way to make both work or remove the feature flag.

@DanielHabenicht DanielHabenicht added the bug Something isn't working label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant