From 5651b4bb0e3afe0546c3a0a94daf557343b3a178 Mon Sep 17 00:00:00 2001 From: Kevin Day Date: Fri, 17 Jan 2025 13:22:20 -0600 Subject: [PATCH] The filterField() crashes on undefined when the find() returns no results. The `view.utility.ts` has this block of code: ``` const getFilterField = (collectionView: CollectionView, actualFilter: Filter): string => { return collectionView.facets.find(f => f.field === actualFilter.field).name; }; ``` That code assumes that the facet will always have a correct find. So, it has a NULL/undefined error when .name is not found. Then the entire page/site crashes and is unusable when this happens. An easy fix is just to use the `?.` instead of `.`. --- src/app/shared/utilities/view.utility.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/shared/utilities/view.utility.ts b/src/app/shared/utilities/view.utility.ts index c1fd04f53..1b7359585 100644 --- a/src/app/shared/utilities/view.utility.ts +++ b/src/app/shared/utilities/view.utility.ts @@ -169,7 +169,7 @@ const showClearFilters = (collectionView: CollectionView, filters: Filter[]): bo }; const getFilterField = (collectionView: CollectionView, actualFilter: Filter): string => { - return collectionView.facets.find(f => f.field === actualFilter.field).name; + return collectionView.facets.find(f => f.field === actualFilter.field)?.name; }; const getFilterValue = (collectionView: CollectionView, actualFilter: Filter): string => {