Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Buffer polyfill patch from @web5/dids once 'buffer' package has been updated #253

Open
frankhinek opened this issue Nov 1, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@frankhinek
Copy link
Contributor

Tracking update to this code:

// monkeypatch writeBigUInt64BE in polyfill bc its borked
// can remove this if/when this PR is merged: https://github.com/feross/buffer/pull/280
polyfilledBuffer.prototype.writeBigUInt64BE = Buffer.prototype.writeBigUInt64BE;
globalThis.Buffer = polyfilledBuffer;

The changes in buffer PR 280 were merged in PR 334 but it doesn't appear that package has been published to NPM registry for years (last version is 6.0.3).

@frankhinek frankhinek added the dependencies Pull requests that update a dependency file label Nov 1, 2023
@mistermoe
Copy link
Member

feross/buffer#335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants