From 4a39df1205b791fe0480e0c8662de9a18a0ecf92 Mon Sep 17 00:00:00 2001 From: Podugu Rohith Surya Date: Sun, 17 Sep 2023 08:02:06 -0700 Subject: [PATCH] [#12276] Instructor edit session page: Fix custom visibility table overflow (#12574) * Use responsive-table class to add scrollbar when table overflows * Update snapshots according to UI changes --------- Co-authored-by: Jason Qiu Co-authored-by: Cedric Ong <67156011+cedricongjh@users.noreply.github.com> --- .../question-edit-form.component.spec.ts.snap | 4 + .../visibility-panel.component.html | 44 +- ...r-session-edit-page.component.spec.ts.snap | 1092 +++++++++-------- 3 files changed, 579 insertions(+), 561 deletions(-) diff --git a/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap b/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap index ff17dc5d3f7..6a053f54ffd 100644 --- a/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap +++ b/src/web/app/components/question-edit-form/__snapshots__/question-edit-form.component.spec.ts.snap @@ -407,6 +407,10 @@ exports[`QuestionEditFormComponent should snap with default view 1`] = ` +
+
diff --git a/src/web/app/components/visibility-panel/visibility-panel.component.html b/src/web/app/components/visibility-panel/visibility-panel.component.html index 82957f78264..425928a1cad 100644 --- a/src/web/app/components/visibility-panel/visibility-panel.component.html +++ b/src/web/app/components/visibility-panel/visibility-panel.component.html @@ -24,28 +24,30 @@
- - - - - - - - - - - - +
+
User/Group{{ visibilityControl | visibilityControlName }}
{{ visibilityType | visibilityTypeName }} - -
+ + + + - - -
User/Group{{ visibilityControl | visibilityControlName }}
+ + + + + {{ visibilityType | visibilityTypeName }} + + + + + + + +
This is the visibility hint as seen by the feedback giver:
    diff --git a/src/web/app/pages-instructor/instructor-session-edit-page/__snapshots__/instructor-session-edit-page.component.spec.ts.snap b/src/web/app/pages-instructor/instructor-session-edit-page/__snapshots__/instructor-session-edit-page.component.spec.ts.snap index 4a556b097b5..0001bb43f3c 100644 --- a/src/web/app/pages-instructor/instructor-session-edit-page/__snapshots__/instructor-session-edit-page.component.spec.ts.snap +++ b/src/web/app/pages-instructor/instructor-session-edit-page/__snapshots__/instructor-session-edit-page.component.spec.ts.snap @@ -1779,181 +1779,185 @@ exports[`InstructorSessionEditPageComponent should snap with feedback session qu
- - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - -
- User/Group - - Can see answer - - Can see giver's name - - Can see recipient's name -
- +
- Recipient(s) - - - - - - - - -
- + - Giver's Team Members - - - - - - - - -
- + - Other students - - - - - - - - -
- + - Instructors - - - - - - - - -
+ Can see recipient's name + + + + + + + + Recipient(s) + + + + + + + + + + + + + + + + Giver's Team Members + + + + + + + + + + + + + + + + Other students + + + + + + + + + + + + + + + + Instructors + + + + + + + + + + + + + + +
@@ -2502,181 +2506,185 @@ exports[`InstructorSessionEditPageComponent should snap with feedback session qu
- - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - -
- User/Group - - Can see answer - - Can see giver's name - - Can see recipient's name -
- +
- Recipient(s) - - - - - - - - -
- + - Giver's Team Members - - - - - - - - -
- + - Other students - - - - - - - - -
- + - Instructors - - - - - - - - -
+ Can see recipient's name + + + + + + + + Recipient(s) + + + + + + + + + + + + + + + + Giver's Team Members + + + + + + + + + + + + + + + + Other students + + + + + + + + + + + + + + + + Instructors + + + + + + + + + + + + + + +
@@ -4546,215 +4554,219 @@ exports[`InstructorSessionEditPageComponent should snap with new question added
- - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - - + + + + + - - - - - -
- User/Group - - Can see answer - - Can see giver's name - - Can see recipient's name -
- +
- Recipient(s) - - - - - - - - -
- + - Giver's Team Members - - - - - - - - -
- + - Recipient's Team Members - - - - - - - - -
- + - Other students - - - - - - - - -
- +
+ + Recipient(s) + + - Instructors - - - - - - - -
+ + + + + + + + + + + + + Giver's Team Members + + + + + + + + + + + + + + + + Recipient's Team Members + + + + + + + + + + + + + + + + Other students + + + + + + + + + + + + + + + + Instructors + + + + + + + + + + + + + + +