[#12048] Migrate tests for GetCoursesActionTest #13232
Conversation
…S#13200) * Migrate DeleteAccountActionTest * Fix checkstyle * Modify tests in DeleteAccountActionTest.java * Update method name in DeleteAccountActionTest
| Const.ParamsNames.ENTITY_TYPE, Const.EntityType.INSTRUCTOR, | ||
| Const.ParamsNames.COURSE_STATUS, Const.CourseStatus.ACTIVE, | ||
| }; | ||
| GetCoursesAction a = getAction(params); |
There was a problem hiding this comment.
nit: lets use the full name for the variable, action to make it easier to follow
| }; | ||
| GetCoursesAction a = getAction(params); | ||
| JsonResult result = a.execute(); | ||
| CoursesData x = (CoursesData) result.getOutput(); |
There was a problem hiding this comment.
nit: similarly, lets use a more descriptive variable name here like data
| JsonResult result = a.execute(); | ||
| CoursesData x = (CoursesData) result.getOutput(); | ||
| assertEquals(1, x.getCourses().size()); | ||
| assertEquals(stubCourse.getId(), x.getCourses().get(0).getCourseId()); |
There was a problem hiding this comment.
Similarly for student lets add 1 more assertion here for this:
| assertEquals(stubCourseList.size(), x.getCourses().size()); | ||
| assertEquals(stubCourseList.get(0).getId(), x.getCourses().get(0).getCourseId()); |
There was a problem hiding this comment.
Lets add 1 more assertion to check for the privileges that are set in the action here:
teammates/src/main/java/teammates/ui/webapi/GetCoursesAction.java
Lines 157 to 173 in d1930b5
| assertEquals(stubCourseList.size(), x.getCourses().size()); | ||
| assertEquals(stubCourseList.get(0).getId(), x.getCourses().get(0).getCourseId()); |
There was a problem hiding this comment.
Lets add the assertion to check for the privileges here too
| List<Instructor> instructorListStub; | ||
| Instructor instructorStub; |
There was a problem hiding this comment.
I thinking if we should store these as attributes of the main class and init them using @BeforeMethod like in previous PR
This would help to simplify some of the mocking logic for eg., when(mockLogic.getInstructorsForGoogleId(stubInstructorObject.getInstructorStub().getGoogleId())).thenReturn(stubInstructorObject.getInstructorListStub());
to
when(mockLogic.getInstructorsForGoogleId(stubInstructor.getGoogleId())).thenReturn(stubInstructorList);
Part of #12048
Outline of Solution
Change GetCoursesActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.