Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too few arguments, still happening #799

Closed
MethylBromide opened this issue Dec 21, 2020 · 3 comments
Closed

Too few arguments, still happening #799

MethylBromide opened this issue Dec 21, 2020 · 3 comments

Comments

@MethylBromide
Copy link

Warning: sprintf(): Too few arguments in …/class-bulk-upgrader-skin.php on line 152

Fix is described here: https://gist.github.com/al5dy/965d0eefffab32df3b04badbc2274d08

Please make the indicated code change on line 24 of class-tgm-plugin-activation.php -- the string skin_update_successful is used in a context where sprintf is called with one data argument, and the formatting string you are assigning currently has two placeholders.

@RupW
Copy link

RupW commented Dec 21, 2020

This probably best as a pull request, if you can make one please?

@jrfnl
Copy link
Contributor

jrfnl commented Dec 21, 2020

This has already been fixed in the code here. There are a number of other things though which a release is waiting on, pull requests for those are very welcome.

@jrfnl
Copy link
Contributor

jrfnl commented Dec 21, 2020

Marking this as a duplicate of #669 which was fixed by #670.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants