Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile fails #143

Open
scifiss opened this issue Nov 15, 2024 · 5 comments
Open

Compile fails #143

scifiss opened this issue Nov 15, 2024 · 5 comments
Assignees
Labels
Improvement Something could be better

Comments

@scifiss
Copy link

scifiss commented Nov 15, 2024

Dear TGS MDIO Cpp,

My gcc version:
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

I have passed the CMake, but can't do make. Here is the result:

(ss-dev-mg) gaor@BEGW-SF-898244:~/Documents/research/mdio/mdio-cpp-main/build$ make
[ 0%] Built target nlohmann_json_schema_validator
[ 0%] Built target tensorstore_internal_poly_storage
[ 0%] Built target tensorstore_internal_utf8
[ 0%] Built target absl_spinlock_wait
[ 0%] Built target absl_log_severity
[ 0%] Built target absl_raw_logging_internal
[ 0%] Built target absl_base
[ 0%] Built target absl_strings_internal
[ 0%] Built target absl_throw_delegate
[ 0%] Built target absl_int128
[ 0%] Built target absl_string_view
[ 0%] Built target absl_strings
[ 0%] Built target tensorstore_util_quote_string
[ 0%] Built target riegeli_base_assert
[ 0%] Built target riegeli_bytes_write_int_internal
[ 0%] Built target absl_malloc_internal
[ 0%] Built target absl_strerror
[ 0%] Built target absl_time_zone
[ 0%] Built target absl_debugging_internal
[ 0%] Built target absl_stacktrace
[ 0%] Built target absl_utf8_for_code_point
[ 0%] Built target absl_decode_rust_punycode
[ 0%] Built target absl_demangle_rust
[ 0%] Built target absl_demangle_internal
[ 0%] Built target absl_symbolize
[ 0%] Built target absl_exponential_biased
[ 0%] Built target absl_graphcycles_internal
[ 0%] Built target absl_civil_time
[ 0%] Built target absl_time
[ 0%] Built target absl_kernel_timeout_internal
[ 5%] Built target absl_synchronization
[ 5%] Built target absl_hashtablez_sampler
[ 5%] Built target absl_bad_variant_access
[ 5%] Built target absl_city
[ 5%] Built target absl_low_level_hash
[ 5%] Built target absl_bad_optional_access
[ 5%] Built target absl_hash
[ 5%] Built target absl_raw_hash_set
[ 5%] Built target absl_crc_cpu_detect
[ 5%] Built target absl_crc_internal
[ 5%] Built target absl_str_format_internal
[ 5%] Built target absl_crc32c
[ 5%] Built target absl_crc_cord_state
[ 5%] Built target absl_cord_internal
[ 5%] Built target absl_cordz_functions
[ 5%] Built target absl_cordz_handle
[ 5%] Built target absl_cordz_info
[ 5%] Built target absl_cord
[ 5%] Built target absl_status
[ 5%] Built target absl_statusor
[ 5%] Built target riegeli_base_memory_estimator
[ 5%] Built target riegeli_base_string_utils
[ 5%] Built target riegeli_base_cord_utils
[ 5%] Built target riegeli_base_buffer
[ 5%] Built target riegeli_base_shared_buffer
[ 5%] Built target riegeli_base_sized_shared_buffer
[ 5%] Built target riegeli_base_zeros
[ 5%] Built target riegeli_base_chain
[ 5%] Built target riegeli_base_object
[ 5%] Built target riegeli_base_status
[ 11%] Built target riegeli_bytes_reader_and_writer
[ 11%] Built target riegeli_varint_varint_reading
[ 11%] Built target absl_examine_stack
[ 11%] Built target absl_log_internal_conditions
[ 11%] Built target absl_log_internal_globals
[ 11%] Built target absl_log_internal_format
[ 11%] Built target absl_log_internal_proto
[ 11%] Built target absl_log_internal_fnmatch
[ 11%] Built target absl_vlog_config_internal
[ 11%] Built target absl_log_globals
[ 11%] Built target absl_log_entry
[ 11%] Built target absl_log_sink
[ 11%] Built target absl_log_internal_log_sink_set
[ 11%] Built target absl_log_internal_nullguard
[ 11%] Built target absl_log_internal_message
[ 11%] Built target tensorstore_internal_riegeli_delimited
[ 11%] Built target absl_log_internal_check_op
[ 11%] Built target tensorstore_serialization
[ 11%] Built target tensorstore_util_status
[ 11%] Built target tensorstore_index_interval
[ 11%] Built target tensorstore_static_cast
[ 11%] Built target tensorstore_rank
[ 11%] Built target tensorstore_util_constant_vector
[ 11%] Building CXX object _deps/tensorstore-build/CMakeFiles/tensorstore_box.dir/tensorstore/box.cc.o
In file included from /home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.h:34,
from /home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.cc:15:
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/internal/multi_vector.h: In substitution of ‘template<long int Extent, class ... Ts> using MultiVectorStorage = tensorstore::internal::MultiVectorStorageImpl<tensorstore::RankConstraint::FromInlineRank(Extent).tensorstore::RankConstraint::operator tensorstore::DimensionIndex(), tensorstore::InlineRankLimit(Extent), Ts ...> [with long int Extent = Rank; Ts = {long int, long int}]’:
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.h:143:67: required from here
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/internal/multi_vector.h:106:58: warning: taking address of rvalue [-fpermissive]
106 | MultiVectorStorageImpl<RankConstraint::FromInlineRank(Extent),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/internal/multi_vector.h:107:58: error: no matching function for call to ‘tensorstore::RankConstraint::operator tensorstore::DimensionIndex(tensorstore::RankConstraint*)’
107 | InlineRankLimit(Extent), Ts...>;
| ^
In file included from /home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/internal/multi_vector.h:30,
from /home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.h:34,
from /home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.cc:15:
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/rank.h:126:13: note: candidate: ‘constexpr tensorstore::RankConstraint::operator tensorstore::DimensionIndex() const’
126 | constexpr operator DimensionIndex() const { return rank; }
| ^~~~~~~~
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/rank.h:126:13: note: candidate expects 0 arguments, 1 provided
In file included from /home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.cc:15:
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.h:220:44: error: expected template-name before ‘<’ token
220 | class Box : public internal_box::BoxStorage {
| ^
/home/gaor/Documents/research/mdio/mdio-cpp-main/build/_deps/tensorstore-src/tensorstore/box.h:220:44: error: expected ‘{’ before ‘<’ token
cc1plus: warning: unrecognized command line option ‘-Wno-unknown-warning-option’
make[2]: *** [_deps/tensorstore-build/CMakeFiles/tensorstore_box.dir/build.make:79: _deps/tensorstore-build/CMakeFiles/tensorstore_box.dir/tensorstore/box.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:9617: _deps/tensorstore-build/CMakeFiles/tensorstore_box.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

Thank you!

@BrianMichell BrianMichell self-assigned this Nov 15, 2024
@BrianMichell BrianMichell added the Improvement Something could be better label Nov 15, 2024
@BrianMichell
Copy link
Collaborator

Hello, and thank you for testing out this repo!

Your issue stems from an unsupported GCC compiler version. We require at least GCC 11 or Clang 14. You can check out our devcontainer as a way to check out things quickly.

The long-term solution will be to have one of the newer compilers mentioned above (or try a different one if they're already available on your system), or we can look into Singularity if your system uses that.

On our side I will look into adding an explicit error for unsupported compiler versions on the CMake side.

@scifiss
Copy link
Author

scifiss commented Nov 16, 2024 via email

@BrianMichell
Copy link
Collaborator

Hi Rebecca,

We actually maintain a custom fork of Tensorstore to enable some key features of MDIO. I believe if you update your fetch content to fetch our fork that will fix your issue.

If this doesn't resolve the issue I'll take a deeper look at the errors.

Best,
Brian

@scifiss
Copy link
Author

scifiss commented Nov 20, 2024 via email

@brian-michell
Copy link

Hi Rebecca,

It looks like your CMake cache is outdated and pointing to the Google managed Tensorstore artifacts still. Removing the contents of the build directory and re-running cmake .. should resolve this issue.

Best,
Brian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Something could be better
Projects
None yet
Development

No branches or pull requests

3 participants