-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Plugin for OPS #125
Comments
(Just recording the results of a previously internal evaluation:) Submission worked fine, entering metadata worked fine, but there seem to be issues with the integration of the map in the theme. The hook names are different and need to be changed.
This requires conditional checking for the base software used and then calling the right hook. |
A quick check is documented in this commit in the branch Renaming the hook names works for article views! |
Other plugins seem to handle this by simply calling multiple handlers: https://github.com/pkp/googleScholar/blob/4bf4dad2be7389898af4458f307413fa2b0c93ff/GoogleScholarPlugin.php#L40 though this requires to call only generic functions, so in our case conditional checking is probably needed. For example, to fix the HTML metadata in the HEAD, simply doing HookRegistry::register('PreprintHandler::view', array(&$this, 'extendArticleView')); does not work
|
The text was updated successfully, but these errors were encountered: