Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords #17

Open
drewroberts opened this issue Feb 23, 2021 · 3 comments
Open

Keywords #17

drewroberts opened this issue Feb 23, 2021 · 3 comments
Assignees
Labels
model description Description of a model Perpetual Never ending issues

Comments

@drewroberts
Copy link
Member

Keywords are stored lowercase and need to have the ability for slight variations to be grouped together with a parent keyword relationship.

Keywords will also belong to a Keyword Type (#16).

Keywords are created in each project by the Admin, Owners or Staff roles (TIPOFF/authorization#21) in the admin section (Laravel Nova).

Datetime for tracking requested and for when a keyword should no longer be tracked in the Rankings.

Later there will be options to approve ones that can be pulled from the Google Search Console API.

This was referenced Feb 23, 2021
@drewroberts drewroberts self-assigned this Feb 23, 2021
drewroberts added a commit that referenced this issue Feb 23, 2021
chx2 added a commit that referenced this issue Feb 24, 2021
chx2 added a commit that referenced this issue Feb 24, 2021
@arwaawan3
Copy link
Contributor

The keywords migration has a comment to add keyword_type_id, should I add it to the migration? I believe the model requires keywords to have keyword_type_id.

@joshtorres
Copy link
Member

joshtorres commented Mar 3, 2021

The keywords migration has a comment to add keyword_type_id, should I add it to the migration? I believe the model requires keywords to have keyword_type_id.

Yes @arwaawan3 please add that if it isn't already there now

@drewroberts
Copy link
Member Author

I ended up deciding that Keyword Types should just be a string field named type and classes for each of the types. You can read more here:

@drewroberts drewroberts added model description Description of a model Perpetual Never ending issues labels Mar 14, 2021
drewroberts added a commit that referenced this issue Mar 18, 2021
@joshtorres joshtorres linked a pull request Apr 4, 2021 that will close this issue
@drewroberts drewroberts removed a link to a pull request Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model description Description of a model Perpetual Never ending issues
Projects
None yet
Development

No branches or pull requests

3 participants