Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DePSI water mask is unique per track, but this is not possible, crashes singapore track 18 #68

Open
4 tasks done
Simon-van-Diepen opened this issue Feb 13, 2025 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request In progress Issue currently being worked on Priority-0 Showstopper bugs and crashing AoIs

Comments

@Simon-van-Diepen
Copy link
Contributor

Simon-van-Diepen commented Feb 13, 2025

This causes issues in track 18 over Singapore, @alapadat1 relevant for you.

Currently the parameter filename_water_mask specifies a single water mask in .raw format. However, this file corresponds to a single track as the number of lines and pixels in the file needs to match the crop exactly.

I therefore propose the following changes:

  • Store water masks in a consistent place, /project/caroline/Software/config/caroline-water-masks
  • Give water masks a machine-readable consistent name, e.g. water_mask_sg_singapore_asc_t171.raw (sg_singapore being the parameter depsi_AoI_name)
  • Change the parameter filename_water_mask to do_water_mask, being a boolean 'yes' or 'no'
  • Change the logic in generate_depsi_param_file_txt.py to fill in [] if do_water_mask is 'no', and fill in /project/caroline/Software/config/caroline-water-masks/water_mask_<depsi_AoI_name>_<sensor>_<asc_dsc>_t<track:0>3d>.raw if do_water_mask is 'yes'

@alapadat1 can you generate the water mask for track 18? Then I can start implementing these changes.

@Simon-van-Diepen Simon-van-Diepen added bug Something isn't working enhancement New feature or request Priority-0 Showstopper bugs and crashing AoIs labels Feb 13, 2025
@Simon-van-Diepen Simon-van-Diepen added the In progress Issue currently being worked on label Feb 18, 2025
@Simon-van-Diepen Simon-van-Diepen linked a pull request Feb 18, 2025 that will close this issue
@Simon-van-Diepen Simon-van-Diepen removed a link to a pull request Feb 18, 2025
@Simon-van-Diepen
Copy link
Contributor Author

@alapadat1 the code has been updated, I'm leaving this one open for you to add the water mask of track 18 to the correct location /project/caroline/Software/config/caroline-water-masks/water_mask_sg_singapore_s1_dsc_t018.raw

@Simon-van-Diepen Simon-van-Diepen removed their assignment Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request In progress Issue currently being worked on Priority-0 Showstopper bugs and crashing AoIs
Projects
None yet
Development

No branches or pull requests

2 participants