From a1d942380a317faf82aa4e0de3e17249e168004c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Chris=20M=C3=BCller?= <2566282+brotkrueml@users.noreply.github.com> Date: Sun, 25 Aug 2024 09:46:41 +0200 Subject: [PATCH] [TASK] Mark properties as private in AdminModuleController (#283) As the class is defined as final, it does not make sense to set the properties as protected as this class cannot be extended. Releases: main, 12.4 --- Classes/Controller/AdminModuleController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/Controller/AdminModuleController.php b/Classes/Controller/AdminModuleController.php index cda36e3..1167b68 100644 --- a/Classes/Controller/AdminModuleController.php +++ b/Classes/Controller/AdminModuleController.php @@ -31,8 +31,8 @@ final readonly class AdminModuleController { public function __construct( - protected ModuleTemplateFactory $moduleTemplateFactory, - protected IconFactory $iconFactory, + private ModuleTemplateFactory $moduleTemplateFactory, + private IconFactory $iconFactory, private UriBuilder $uriBuilder, // ... ) {}