From a9a0dd9cf306a31ee7e9955fada2737af1f6447b Mon Sep 17 00:00:00 2001 From: Geoffroy Baccarini Date: Fri, 29 Mar 2024 11:04:15 +0100 Subject: [PATCH 1/4] fix(TMC-27716): fix firefox height for fieldset --- .changeset/chatty-cherries-do.md | 5 +++++ .../src/components/Form/Fieldset/Fieldset.module.scss | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 .changeset/chatty-cherries-do.md diff --git a/.changeset/chatty-cherries-do.md b/.changeset/chatty-cherries-do.md new file mode 100644 index 00000000000..a3610da0556 --- /dev/null +++ b/.changeset/chatty-cherries-do.md @@ -0,0 +1,5 @@ +--- +"@talend/design-system": patch +--- + +TMC-27716 - Fix firefox fieldset height diff --git a/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss b/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss index 380e681e673..f6fc9a238d6 100644 --- a/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss +++ b/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss @@ -3,9 +3,8 @@ .fieldset { padding: 0; border: none; - display: flex; - flex-flow: column; gap: tokens.$coral-spacing-s; + display: grid; } .legend { From 61e944428bef772576509eda00f9d37540cb5418 Mon Sep 17 00:00:00 2001 From: Geoffroy Baccarini Date: Fri, 29 Mar 2024 11:23:40 +0100 Subject: [PATCH 2/4] use display contents --- .../src/components/Form/Fieldset/Fieldset.module.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss b/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss index f6fc9a238d6..49c25ca3b49 100644 --- a/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss +++ b/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss @@ -3,8 +3,7 @@ .fieldset { padding: 0; border: none; - gap: tokens.$coral-spacing-s; - display: grid; + display: contents; } .legend { From 3e0159a9615889e631847699c051bcfff40a5809 Mon Sep 17 00:00:00 2001 From: Geoffroy Baccarini Date: Fri, 29 Mar 2024 11:47:02 +0100 Subject: [PATCH 3/4] less painfull fix --- .../src/components/Form/Fieldset/Fieldset.module.scss | 7 ++++++- .../src/components/Form/Fieldset/Fieldset.tsx | 10 ++++++---- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss b/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss index 49c25ca3b49..89d3c439174 100644 --- a/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss +++ b/packages/design-system/src/components/Form/Fieldset/Fieldset.module.scss @@ -3,7 +3,6 @@ .fieldset { padding: 0; border: none; - display: contents; } .legend { @@ -12,3 +11,9 @@ font: tokens.$coral-heading-m; margin: 0; } + +.fieldset-content { + display: flex; + flex-flow: column; + gap: tokens.$coral-spacing-s; +} diff --git a/packages/design-system/src/components/Form/Fieldset/Fieldset.tsx b/packages/design-system/src/components/Form/Fieldset/Fieldset.tsx index 0743f6cd214..e99986fcb78 100644 --- a/packages/design-system/src/components/Form/Fieldset/Fieldset.tsx +++ b/packages/design-system/src/components/Form/Fieldset/Fieldset.tsx @@ -1,5 +1,5 @@ import { Children, cloneElement, forwardRef } from 'react'; -import type { Ref, FieldsetHTMLAttributes } from 'react'; +import type { FieldsetHTMLAttributes, Ref } from 'react'; import { isElement } from 'react-is'; import styles from './Fieldset.module.scss'; @@ -28,9 +28,11 @@ const Fieldset = forwardRef( {required && '*'} )} - {Children.toArray(children).map(child => - isElement(child) ? cloneElement(child, childrenProps) : child, - )} +
+ {Children.toArray(children).map(child => + isElement(child) ? cloneElement(child, childrenProps) : child, + )} +
); }, From 5d699630977b3e64b7baa10e67529c768bab9125 Mon Sep 17 00:00:00 2001 From: Geoffroy Baccarini Date: Fri, 29 Mar 2024 14:22:19 +0100 Subject: [PATCH 4/4] fix tests --- .../__snapshots__/ComponentForm.test.js.snap | 160 ++--- .../Form/__snapshots__/Form.test.tsx.snap | 568 ++++++++--------- .../Array.component.test.js.snap | 594 +++++++++--------- .../Columns.component.test.js.snap | 230 +++---- .../Fieldset.component.test.js.snap | 58 +- .../__snapshots__/Tabs.component.test.js.snap | 114 ++-- 6 files changed, 882 insertions(+), 842 deletions(-) diff --git a/packages/containers/src/ComponentForm/__snapshots__/ComponentForm.test.js.snap b/packages/containers/src/ComponentForm/__snapshots__/ComponentForm.test.js.snap index ddf29f61419..0d535c1bebf 100644 --- a/packages/containers/src/ComponentForm/__snapshots__/ComponentForm.test.js.snap +++ b/packages/containers/src/ComponentForm/__snapshots__/ComponentForm.test.js.snap @@ -14,111 +14,115 @@ exports[`ComponentForm #render should render a UIForm 1`] = ` Metadata
- -
- -
-
-
+ +
+
+
+
+
- -
- -