Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add type safety to graphQL queries and query improvements #79

Open
2 of 3 tasks
UrbanWill opened this issue Sep 13, 2024 · 0 comments
Open
2 of 3 tasks

Comments

@UrbanWill
Copy link
Collaborator

UrbanWill commented Sep 13, 2024

Issue:

Existing graphQl queries are not typed. Untyped queries make it easier for bugs to be introduced, diminishes DX and make it hard to refactor existing queries.

How to add type safety with React-query and graphQl

https://the-guild.dev/graphql/codegen/docs/guides/react-query

What's next

After adding types, we can confidently refactor existing queries that may be slowing down Signet:

  • AddressesByOrgId should only be called when needed and should be paginated. The current limit of 1000 is too high. Consider the effects this may have on useKnownAddresses. Refactor: address input #83
  • TxMetadata should be queried on demand when needed. Also, the 300 limit may be too large, and at the same time too small to cover the entire multisig team's transaction list. Perf: tx-Metadata refactor #87
  • GetTransactions: We are fetching too much data. Consider implementing pagination.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant