You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The way we have structured the database operations and the database setup in code right now is not great practice. We need to make some changes to database.py, engine.py and main.py so that the FastAPI project is using a more industry-accepted structure for the SQLmodel integration.
For instance, we're using async for sqlmodel by using the sqlalchemy Async features and we have a contextmanager to handle sessions.
The text was updated successfully, but these errors were encountered:
I made some updates in the most recent merge to development for #41 but also made it easier to reinitialize the database so that its integrated directly with alembic.
Just FYI if you wanna rebase. Also i did reset the migrations too but if you're happy with your migration scripts then you can keep your changes. It's mainly just about ensuring we have a good process for dealing with enum types. If you want you can put down the rules about editing enums for it to work with the migrations in docs/en/MIGRATIONS.md if you want.
The way we have structured the database operations and the database setup in code right now is not great practice. We need to make some changes to
database.py
,engine.py
andmain.py
so that the FastAPI project is using a more industry-accepted structure for the SQLmodel integration.For instance, we're using async for sqlmodel by using the sqlalchemy Async features and we have a contextmanager to handle sessions.
The text was updated successfully, but these errors were encountered: