Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: Make TorchTrainer use generics #212

Open
EWitting opened this issue Jun 25, 2024 · 1 comment
Open

REF: Make TorchTrainer use generics #212

EWitting opened this issue Jun 25, 2024 · 1 comment
Labels
02 - Refactor Issues related to refactoring code 11 - Trainer Issues related to model trainers needs milestone Marks an issue as needing a milestone

Comments

@EWitting
Copy link
Contributor

To allow proper type checking for epochalyst using mypy, the trorch trainer should be made compatible with using types like XData and YData, that are specified per competition. This can be done with TypeVars and Generics.
@EWitting EWitting added 01 - Enhancement New feature or request 02 - Refactor Issues related to refactoring code 11 - Trainer Issues related to model trainers labels Jun 25, 2024
@EWitting EWitting mentioned this issue Jun 25, 2024
Closed
@schobbejak schobbejak added needs milestone Marks an issue as needing a milestone and removed 01 - Enhancement New feature or request labels Jun 25, 2024
@schobbejak schobbejak changed the title ENH: Make TorchTrainer use generics REF: Make TorchTrainer use generics Jun 25, 2024
@Jeffrey-Lim
Copy link
Contributor

Depends on TeamEpochGithub/agogos#87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02 - Refactor Issues related to refactoring code 11 - Trainer Issues related to model trainers needs milestone Marks an issue as needing a milestone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jeffrey-Lim @EWitting @schobbejak