Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to Make Top Bar Comletely Black #11640

Open
6 tasks done
Mash-em opened this issue Oct 24, 2024 · 0 comments · May be fixed by #11641
Open
6 tasks done

Option to Make Top Bar Comletely Black #11640

Mash-em opened this issue Oct 24, 2024 · 0 comments · May be fixed by #11641
Labels
feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up

Comments

@Mash-em
Copy link

Mash-em commented Oct 24, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Black Top Panel 🖤

Why do you want this feature?

The default Red top bar is distracting in Black Mode.

Additional information

No response
@Mash-em Mash-em added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 24, 2024
chavan-arvind added a commit to chavan-arvind/NewPipe that referenced this issue Oct 24, 2024
@chavan-arvind
Add option to make top bar completely black in Black Mode
7b67aa8 
Fixes TeamNewPipe#11640

Add an option to make the top bar completely black in Black Mode.

* **colors.xml**: Add a new color resource `black_top_bar_color` with value `#000000`.
* **AppearanceSettingsFragment.java**: Add a new preference for enabling the completely black top bar option.
* **activity_main.xml**: Update the toolbar layout to use the new `black_top_bar_color` when the completely black top bar option is enabled.
@chavan-arvind chavan-arvind linked a pull request Oct 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to make top bar completely black in Black Mode chavan-arvind/NewPipe
1 participant
@Mash-em