Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

CreateMaterialPool doesn't use the size_in_bytes variable. Always allocates 1_mb #277

Open
VZout opened this issue May 8, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@VZout
Copy link
Contributor

VZout commented May 8, 2019

d3d12_material_pool.hpp:

m_constant_buffer_pool = m_render_system.CreateConstantBufferPool(1_mb);		

d3d12_renderer.hpp

std::shared_ptr<MaterialPool> D3D12RenderSystem::CreateMaterialPool(std::size_t size_in_bytes)
{
	return std::make_shared<D3D12MaterialPool>(*this);
}
@VZout VZout added the bug Something isn't working label May 8, 2019
@161563
Copy link
Contributor

161563 commented Jun 21, 2019

Created a pull request with the fix (#394)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants