Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken PlayerQuitEvent, plugin totally broken #20

Open
vemacs opened this issue May 26, 2015 · 21 comments
Open

Broken PlayerQuitEvent, plugin totally broken #20

vemacs opened this issue May 26, 2015 · 21 comments

Comments

@vemacs
Copy link

vemacs commented May 26, 2015 

[03:40:03] [Server thread/ERROR]: Could not pass event PlayerQuitEvent to CombatTag v6.4.1-SNAPSHOT
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:305) ~[paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.PlayerList.disconnect(PlayerList.java:372) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.PlayerConnection.a(PlayerConnection.java:849) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.NetworkManager.l(NetworkManager.java:315) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.ServerConnection.c(ServerConnection.java:145) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.MinecraftServer.A(MinecraftServer.java:863) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.DedicatedServer.A(DedicatedServer.java:372) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.MinecraftServer.z(MinecraftServer.java:703) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at net.minecraft.server.v1_8_R2.MinecraftServer.run(MinecraftServer.java:606) [paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]
Caused by: java.lang.NullPointerException
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R2.NMS.makeProfile(NMS.java:111) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R2.NMS.setSkin(NMS.java:91) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.trySetSkin(NMSNPC.java:146) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.spawn(NMSNPC.java:112) ~[?:?]
        at com.trc202.CombatTag.NPCManager.spawnHumanNPC(NPCManager.java:41) ~[?:?]
        at com.trc202.CombatTag.CombatTag.spawnNpc(CombatTag.java:175) ~[?:?]
        at com.trc202.CombatTagListeners.NoPvpPlayerListener.onPlayerQuit(NoPvpPlayerListener.java:81) ~[?:?]
        at sun.reflect.GeneratedMethodAccessor445.invoke(Unknown Source) ~[?:?]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
        at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301) ~[paperspigot.jar:git-PaperSpigot-07ff818-0a645a2]
        ... 12 more
@ams2990
Copy link

ams2990 commented May 31, 2015

The same error with 1.8.6 and c07dc3e:

[ERROR] Could not pass event PlayerQuitEvent to CombatTag v6.4.1-SNAPSHOT
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot.jar:git-Spigot-c5146ba-c637b93]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-c5146ba-c637b93]
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.PlayerList.disconnect(PlayerList.java:346) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:844) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.NetworkManager.l(NetworkManager.java:314) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.ServerConnection.c(ServerConnection.java:145) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:817) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:367) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:657) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:560) [spigot.jar:git-Spigot-c5146ba-c637b93]
        at java.lang.Thread.run(Thread.java:745) [?:1.8.0_45]
Caused by: java.lang.NullPointerException
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R3.NMS.makeProfile(NMS.java:111) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.versions.v1_8_R3.NMS.setSkin(NMS.java:91) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.trySetSkin(NMSNPC.java:146) ~[?:?]
        at com.trc202.CombatTag.libs.npclib.nms.NMSNPC.spawn(NMSNPC.java:112) ~[?:?]
        at com.trc202.CombatTag.NPCManager.spawnHumanNPC(NPCManager.java:41) ~[?:?]
        at com.trc202.CombatTag.CombatTag.spawnNpc(CombatTag.java:175) ~[?:?]
        at com.trc202.CombatTagListeners.NoPvpPlayerListener.onPlayerQuit(NoPvpPlayerListener.java:81) ~[?:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_45]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_45]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_45]
        at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_45]
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot.jar:git-Spigot-c5146ba-c637b93]
        ... 12 more

@Agazed
Copy link

Agazed commented Jun 4, 2015

I confirm

@Agazed
Copy link

Agazed commented Jun 8, 2015

Is this going to be fixed? Plugin is completely broken.

@Techcable
Copy link
Member

It will be fixed, i'll just have to revert one commit 😄

@Agazed
Copy link

Agazed commented Jun 8, 2015

Well, which commit is it? Can you not just do it? I rely on your plugin for my large community and I really need a working version so people stop combat logging.

@Techcable
Copy link
Member

NPCLib@1cddc524ae
Reverting it causes compile errors i have to fix.

@rourke750
Copy link
Contributor

Any news on this?

@Agazed
Copy link

Agazed commented Jun 23, 2015

It's been almost a month this plugin is completely broken. Pretty sure this project is abandoned.... :(

Techcable added a commit to TechzoneMC/NPCLib that referenced this issue Jun 24, 2015
@Techcable
Revert "Try and avoid rate limits on skins by requesting again if fai…
c926483 
…led"

This reverts commit 1cddc52.

Fixes #6
I think this will fix/help with TechzoneMC/CombatTagLegacy#20

Conflicts:
	nms-v1_8_R1/src/main/java/net/techcable/npclib/nms/versions/v1_8_R1/NMS.java
	nms-v1_8_R2/src/main/java/net/techcable/npclib/nms/versions/v1_8_R2/NMS.java
	nms-v1_8_R3/src/main/java/net/techcable/npclib/nms/versions/v1_8_R3/NMS.java
@Techcable
Copy link
Member

Try build #15

@rourke750
Copy link
Contributor

There is no 15

@rourke750
Copy link
Contributor

Nvm there is now

@Techcable
Copy link
Member

@rourke750
It was building 😉

@Agazed
Copy link

Agazed commented Jun 24, 2015

Build 15 still doesnt work. When a player logs out, no entity is produced an there is no error in the console. But it still says to the Admins that a player combat logged.

@Agazed
Copy link

Agazed commented Jun 26, 2015

???????????

@Techcable
Copy link
Member

Try build 18 (latest is better) of Combat Tag 7.0.0 beta

@dwaynehulsman
Copy link

Link is dead, new one please?

@Techcable
Copy link
Member

@xxroltsxx
Fixed.

@dwaynehulsman
Copy link

I'm getting this when a player leaves while tagged: http://pastebin.com/pvYJsJnt

@Techcable
Copy link
Member

@xxroltsxx
Are you sure you are on build 21?

@dwaynehulsman
Copy link

Yes

@Techcable
Copy link
Member

Fixed By NPCLib@79129e903edf8 (build 22)
Since the original issue is fixed, i'm closing this.
And please open a new issue for a new problem @xxroltsxx .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ams2990 @rourke750 @vemacs @Techcable @dwaynehulsman @Agazed