Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation/tags to make docker-socket-proxy more secure for novice users #115

Open
bluepuma77 opened this issue Jan 30, 2024 · 4 comments

Comments

@bluepuma77
Copy link

The README.md shows this usage example:

docker container run \
    -d --privileged \
    --name dockerproxy \
    -v /var/run/docker.sock:/var/run/docker.sock \
    -p 127.0.0.1:2375:2375 \
    tecnativa/docker-socket-proxy

In my optioning the example contains two security risks:

  1. tecnativa/docker-socket-proxy on Docker Hub (link) defaults to latest, which is already 3 years old. Please either update latest tag on Docker Hub to a more current version or add the edge tag to the usage example.
  2. The example uses -privileged, which gives a lot of permissions to the container, even though this is not required, it runs without any issue on plain Debian without the parameter. If there are exceptions, they should be noted, but --privileged should not be assumed to be default, and in 2024 there should be more granular options.

Combining a 3 year old image with --privileged seems to be a very insecure usage example for novice users. The project is intended to improve security, but the example seems very counter-productive.

@pedrobaeza
Copy link
Member

Can you please propose a better text?

@kingp0dd
Copy link

kingp0dd commented Apr 3, 2024

i don't think this is maintained anymore

@pedrobaeza
Copy link
Member

Not really true, as we are here, but lacking some knowledge as the employee behind this is no longer working with us. Any help is appreciated.

@thoniTUB
Copy link

The 1st point seems to be solved now. Latest points to a recent image and logs: haproxy version is 3.0.2-a45a8e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants