Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isFileMode false in udp:// #2

Open
RodrigoDornelles opened this issue Dec 6, 2024 · 1 comment
Open

isFileMode false in udp:// #2

RodrigoDornelles opened this issue Dec 6, 2024 · 1 comment

Comments

@RodrigoDornelles
Copy link

acabei encontrando isso, por que difere da documentação.

tmm/src/tsparser/Muxer.cpp

Lines 121 to 126 in 8a059ba

#if 0 // is this correct?
unsigned found = dest.find("://");
if (found != std::string::npos) {
isFileMode = false;
}
#endif

acredito que deveria ser:

if (dest.find("udp://") == 0) {
   isFileMode = false;
}
@joaorovera
Copy link

acabei encontrando um bug relacionado ao parse de ip, a função MulticastServer::MulticastServer(const char* group, int portNumber) está recebendo group sem os dois primeiros caracters, ou seja 192.168.8.188 faz o print como 2.168.8.188 , acabei modificando esse trecho para resolver, mas não sei a solução definitiva para isso:

tmm/src/tsparser/Muxer.cpp

Lines 199 to 203 in 8a059ba

unsigned found = destination.find("://");
ip.assign(destination, found+3, 25);
found = ip.find(":");
port.assign(ip, found+1, 5);
ip.assign(ip, 0, found);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants