Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug ➾ Taq uninstall command returns successfully when naming a non-existent plugin #1785

Open
1 of 6 tasks
egarson opened this issue Jan 18, 2023 · 0 comments
Open
1 of 6 tasks

🐛 Bug ➾ Taq uninstall command returns successfully when naming a non-existent plugin #1785

egarson opened this issue Jan 18, 2023 · 0 comments
Labels
bug Something isn't working triage Requires triage

Comments

@egarson
Copy link
Contributor

egarson commented Jan 18, 2023 •
edited
Loading

🚥 Status (Internal Taqueria Team Use Only)

  • 🔬 Investigated and Verified
  • ⚗️ Solution Identified and Designed
  • 🧫 Dev Implementation of Fix
  • 🧪 Fix Tested and Validated
  • 🏆 PR Merged

🆘 What happened?

Doing a taq uninstall non-existent-plugin returns Plugin uninstalled successfully.

The problem this poses is that a developer might think they have uninstalled a plugin they thought they did, but they haven't (of course).

The expected behavior is for taq to return Plugin "non-existent-plugin" not found.

🆘 Steps to Reproduce?

Type taq uninstall <blah> in a root Taqueria project.

🪵 Relevant log output

➜  taqueria-scaffold-taco-shop git:(1325-refactor-taco-shop-tests) ✗ taq uninstall non-existent-plugin

up to date, audited 624 packages in 4s

...

found 0 vulnerabilities
Plugin uninstalled successfully

🐘 How impactful is this bug?

🤔 Notable but managable

🌮 Taqueria Version

  • v0.26.28-rc

🌿 Node.js Version

v16.19.0

Code of Conduct

  • I agree to follow this project's Code of Conduct
@egarson egarson added bug Something isn't working triage Requires triage labels Jan 18, 2023
@michaelkernaghan michaelkernaghan removed their assignment Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working triage Requires triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egarson @michaelkernaghan