Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Move GenesisDoubleDropsWall from Genesis over to Nitrogen #32

Open
Zepalesque opened this issue May 25, 2024 · 1 comment

Comments

@Zepalesque
Copy link

My request is to move the GenesisDoubleDropsWall class from Genesis over to Nitrogen

The reason this would be helpful is for addon creators who want to use log walls, so they don't need to copy that class if they want them to have double drops.

Plus, Nitrogen already has datagen for log walls so it'd make a lot of sense to have the actual class as well.

@Zepalesque
Copy link
Author

Zepalesque commented May 25, 2024

oh, another thing that'd be helpful is for the fixShapeMaps and fixShapeMap methods in the class to be protected rather than private and for fixShapeMap to be non-static (plus return the ImmutableMap.Builder<BlockState, VoxelShape>), I have a specific use case where extending them would be useful
edit: okay actually nevermind, after testing the implementation I had in mind for extension, that did not work 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Back Log
Development

No branches or pull requests

1 participant