Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Quickstart guide link broken #2912

Open
WickedStereo opened this issue Mar 6, 2025 · 5 comments
Open

Git Quickstart guide link broken #2912

WickedStereo opened this issue Mar 6, 2025 · 5 comments
Assignees

Comments

@WickedStereo
Copy link

Description

The link to the Git Quickstart guide in the file docs/contrib/DeveloperGuide.md is broken and returns a 404 Not Found error.

Steps to Reproduce

  1. Navigate to docs/contrib/DeveloperGuide.md in the repository.
  2. Click on the link to the Git Quickstart guide (last point in the file)

Image

Suggested Solution

Update the link to a valid Git Quickstart guide.

Additional Context

No response

@luarss
Copy link
Contributor

luarss commented Mar 7, 2025

Hi, please refer to this link for the timebeing https://openroad-flow-scripts.readthedocs.io/en/latest/contrib/GitGuide.html

The actual file does not exist in the repo because we share the same Git Quickstart guide with OR repo.

@WickedStereo
Copy link
Author

WickedStereo commented Mar 8, 2025

Thanks for letting me know. Do you want me to add the doc from OR to the ORFS repo or else, change the doc link to the OR repo doc and submit a pull request?

@maliberty
Copy link
Member

I don't want to have two copies that can drift apart. Is there a way we can make the link work when viewed from GH?

@WickedStereo
Copy link
Author

That's right! A simple solution is to use the absolute URL to the file from OR. The only issue is that it would always point to github and not work locally.
I checked other possible solutions which include creating submodules or automation using github actions.

@luarss
Copy link
Contributor

luarss commented Mar 8, 2025

Thats not the only thing that needs to change.

https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/blob/master/docs/conf.py

In our setup we download the markdown, do regex swap for OR into ORFS then render it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants