Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Adding a new category for Sequences #210

Open
SpiderMath opened this issue Oct 19, 2023 · 3 comments
Open

[FEATURE]: Adding a new category for Sequences #210

SpiderMath opened this issue Oct 19, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@SpiderMath
Copy link
Contributor

Motivation

TypeScript (and JavaScript) has the capability of using Generator functions, which can help us in generating sequences.
There already exists a category for Sequences, which was made for C# to make use of the existence of generator methods in C# (from what was told to me by one of the maintainers of the C# repository).
Since TypeScript also has generators, we could also add implementations for those sequences on the Website under this category. We could also add many more entries under this category, for there are many sequences whose implementations are non-trivial but not added there yet.

Examples

We could add this to increase coverage of the entries under the cateogry of Sequences, which would also look less confusing, for when someone may look at the website, it can be confusing so as to why there's only C# implementations under those sequences.

Possible workarounds

No response

@SpiderMath SpiderMath added the enhancement New feature or request label Oct 19, 2023
@appgurueu
Copy link
Contributor

appgurueu commented Oct 20, 2023

Agreed. Sequences should be implemented as generators (where possible) and get a subcategory in the maths folder.

@SpiderMath
Copy link
Contributor Author

Agreed. Sequences should be implemented as generators (where possible) and get a subcategory in the maths folder.

Yes. Just one question, Sequences already exists as a category separate to that of Maths on the website, so if we put sequences as a sub-category to maths in our file structures, then would it not lead to duplicate entries? How shall we prevent that?

@appgurueu
Copy link
Contributor

appgurueu commented Oct 21, 2023

From taking a brief look at the website code, I think it would be under the both the "maths" and "sequences" categories then, which seems reasonable: https://github.com/TheAlgorithms/website/blob/1d72fe67726e333d64cbaa48a7812231e3348c1f/scripts/fetch-algorithms.ts#L114-L122.

If not, esp. if it'd just be under the maths category, that would be a website issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants