Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight negative Bucket balance with red color #293

Closed
TheAxelander opened this issue Feb 15, 2025 · 9 comments · Fixed by #300
Closed

Highlight negative Bucket balance with red color #293

TheAxelander opened this issue Feb 15, 2025 · 9 comments · Fixed by #300
Labels
Milestone

Comments

@TheAxelander
Copy link
Owner

From Discussion #292

I find it not so easy to see what bucket that has a balance that is in minus, that would be marked as red or something in the bucket line or maybe that where the Data Consistency comes in?

@YannisAm
Copy link
Contributor

I will try that if no one is interested

@YannisAm
Copy link
Contributor

YannisAm commented Feb 21, 2025

Maybe is better to make all negatives in the bucket red.

It will look like this if the balance is positive

Image

Or like this if the balance is negative

Image

@TheAxelander
Copy link
Owner Author

The intention was to make the numbers red (and maybe also green) in each listed Bucket for things like Blance. But that one could be also nice

@YannisAm
Copy link
Contributor

How do you want to proceed?

Make only balance red and everything positive green?

Or

Leave it like that and make positives green?

@TheAxelander
Copy link
Owner Author

Let me try to explain, I think there is a small misunderstanding.

You can do it like in the second screenshot with an addition that positive figures are shown green too.
My initial plan was to show red and green figures in below area. But feel free if you want to do this

Image

@YannisAm
Copy link
Contributor

I believe now we are on the same page.
Positives are show green, negatives are show red and zero is shown the default color.

In the bucket section I changed only the balance color.

Image

Feel free to tell me if you need to change anything else

@TheAxelander
Copy link
Owner Author

Awesome, looking great. Feel free to draft a PR for that.

One point, and let me know what you think, for Pending Want I would make the number red once it's larger than 0 (because there is still money to be budgeted). If it's 0 then make it green. Lower than 0 should not happen (otherwise it's a bug)

@YannisAm
Copy link
Contributor

I see your point, but red is often associated with negativity. Using red might draw attention away from what we actually want to highlight. I suggest using a different color, like orange, to make it stand out while still conveying importance.

@YannisAm
Copy link
Contributor

What do you think about that?

Image

@TheAxelander TheAxelander moved this from 📋 Backlog to 🔖 Ready for next version in OpenBudgeteer Development Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔖 Ready for next version
Development

Successfully merging a pull request may close this issue.

2 participants