Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pydantic models #23

Open
GooseLF opened this issue Jun 23, 2022 · 2 comments
Open

Implement Pydantic models #23

GooseLF opened this issue Jun 23, 2022 · 2 comments
Assignees

Comments

@GooseLF
Copy link
Contributor

GooseLF commented Jun 23, 2022

@gvee-uk Please implement pydantic models so we can have strong type checking :D

@gvee-uk
Copy link
Contributor

gvee-uk commented Jun 24, 2022

Adding to this: dataclasses allow for type hints, but not type checking.
To do strict type checking you need to roll your own __post_init__ method with custom code.
pydantic models give you the strong type checking "for free".

@GooseLF
Copy link
Contributor Author

GooseLF commented Jun 24, 2022

Need to re-enabled the skipped test when this is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants