Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Possible Incompatibility with LuckPerms #463

Closed
hypherionmc opened this issue Dec 9, 2024 · 4 comments
Closed

[Bug]: Possible Incompatibility with LuckPerms #463

hypherionmc opened this issue Dec 9, 2024 · 4 comments
Assignees
Labels
status: resolved This issue or pull request has been resolved type: bug Something isn't working

Comments

@hypherionmc
Copy link

Minecraft Version

1.20.1

What happened?

Not really sure if this is a curios bug, or LuckPerms bug, but reporting to both, just in case.

Basically, when you have a mod installed that uses the LuckPerms getCachedData() api, it will break when the player dies, causing the player to become completely unresponsive, unable to completely respawn

One of my users came across this, and I can confirm the bug.

Original report: hypherionmc/sdlink#136

How do you trigger this bug?

  1. Install Curios and LuckPerms
  2. Install CraterLib, Simple Discord Link (No need to configure either, it's enough to just install them)
  3. Let the player die and respawn. If you respawn, you will be unable to do anything, and if you relog, you will be on the death screen again, with the error linked below printed to the logs.

Loader

Forge

Loader Version

47.3.12

Mod Version

5.11.0+1.20.1

Relevant Log Outputs

https://pastebin.com/4wsRNRYF

@hypherionmc hypherionmc added status: triage This issue or pull request is awaiting review type: bug Something isn't working labels Dec 9, 2024
@TheIllusiveC4 TheIllusiveC4 added status: pending This issue or pull request is pending further information or consideration and removed status: triage This issue or pull request is awaiting review labels Jan 3, 2025
@TheIllusiveC4
Copy link
Owner

I'm having some difficulty trying to debug LuckPerms in a development environment, so unfortunately I couldn't be as thorough as I wanted in my investigation of this issue. However, from what I can tell, this seems to be an issue that needs to be fixed on LuckPerms's end.

The log output doesn't show Curios in the stacktrace so I'm a bit confused what could cause this issue to arise from Curios's end, but the failure to load player data seems to happen purely with LuckPerms's code so I don't believe there's a possible workaround I could do on my end to address this either.

@hypherionmc
Copy link
Author

Hey

Thanks for the feedback. About a week after this bug report, we got another almost identical one. This time, removing both curios and my mod did not fix it, so it's definitely a core bug in LuckPerms itself.

The other report was because of Styled Chat. I don't have a lot of hope that it will be fixed on their side (since they drop support for older mc as soon as they port) 😢

@TheIllusiveC4
Copy link
Owner

Ah, I see. That's unfortunate then, if it's not likely to be fixed. But if that's the case, I'll go ahead and close this issue since it doesn't seem to be caused by Curios. However, feel free to let me know if there's any update on this issue that requires another look at it.

@TheIllusiveC4 TheIllusiveC4 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
@TheIllusiveC4 TheIllusiveC4 added status: resolved This issue or pull request has been resolved and removed status: pending This issue or pull request is pending further information or consideration labels Jan 3, 2025
@hypherionmc
Copy link
Author

Update: This has been a bug in LuckPerms since Sept 2023 at least..... LuckPerms/LuckPerms#3747

The list of mods affected by this keep growing.

Aside from curios, there is now also

  • Styled Chat
  • Better Forge Chat

and I saw a user in my discord mention architectury api, but not sure if that is the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved This issue or pull request has been resolved type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants