Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpth doesn't re-insert data from jsons to exif #195

Open
wicked-head opened this issue Apr 10, 2023 · 9 comments
Open

gpth doesn't re-insert data from jsons to exif #195

wicked-head opened this issue Apr 10, 2023 · 9 comments
Labels
exif Related to exif - or lack fo them in gpth.dart

Comments

@wicked-head
Copy link

Hi, first let me thank you for your dedication and sharing this tool to the world!

I performed a test by manually removing some tags from the file even if the information was already in the json file and it did not did copy everything.
Example:
Step 1) Right click on image -> Properties -> Details -> Remove Properties and Personal Information -> deleted "Date Taken", "GPS information", Title, "subject"
Step 2) ran the gpth-windoza.exe with admin rights
Step 3) target photo only changed the "Last Modified Date" is now same date as in the JSON "photoTakenTime" tag.
But it is Missing: "Date Taken", "GPS" information (Lat, Long, Alt), Title and Description tags could also be copied. This information is present on the JSON file but was not on the original file metadata as part of my test, and my expectation was that (at least) the GPS information would been enriched by your program.

Additionally, shouldnt it also change the "Date Created" tag? or is that not accessible to overwrite?

Is it something that could be easily done as you already have the framework to do it?

Thanks for all the good work :)

@TheLastGimbus
Copy link
Owner

Hi! Nice of you to help with testing!

I tried times and times to find nice exif library/solution for Dart, but it seems very difficult, so gpth currently doesn't modify image metadata at all

See discussion here: #191

If you want this very much, please write there se we can discuss <3

@TheLastGimbus TheLastGimbus changed the title Some parameters are not being copied from JSON gpth doesn't re-insert data from jsons to exif May 3, 2023
@TheLastGimbus TheLastGimbus added the exif Related to exif - or lack fo them in gpth.dart label May 3, 2023
@bartaspoz
Copy link

bartaspoz commented Jun 19, 2023

Hey! Thanks for your awesome tool. In the readme, in TODO section there is an info about moving GPS data from json to exif which states that this is working for python version. So could you tell me, do I need to use the 2.x release in order to propely move GPS data to exif?
If yes, is it possible to re-run the python version on top of already alredy parsed data by most recent version?

I've downloaded, extracted and run the newest version of your toole. I have now input folder with all Json files, and output folder, nicely arranged by dates, but without json files. Am I able to somehow run the 2.x version to apply the exif data on photos?

@TheLastGimbus
Copy link
Owner

is it possible to re-run the python version on top of already alredy parsed data by

I don't think so, and I don't recommend touching python version at all - it was a mess, and I can't tell you for sure what will happen

I think the fastest would be to write a new 20-line python script that would do that - tho it wouldn't have any advanced json matching like whole gpth has

...or, I could add experimental feature to gpth to generate a exiftool-based bash script to set all of those locations

what do you think?

@bartaspoz
Copy link

Hi, any way of preserving gps data would be a gamechanger. I use photos location history constantly, as I travel a lot and like to re-visit places by searching for them on the map. My idea is to import Goole Takeout to Synology Photos, where the map feature is present as well.

So I tkink your last idea is the one that I like the most :)
I would love to help you, but I'm not a programmer.

@TheLastGimbus
Copy link
Owner

Wait, but... as I tried to reaserch, as in #191 , GPhotos doesn't strip exifs - I don't remember any precisely observed case of this - so, did you actaully check if your photos in your takeout have exifs? (Exif is metadata format that contains the location info). If they do have it, you don't need to re-merge that fom jsons...

If all of your photos have this stripped, then i want to investigate this very intense - did you have an iphone, or did most of your photos did not have gps data from camera, but you manually edited that in gphotos app? @bartaspoz

@alexander-myltsev
Copy link

Hi. Thanks for your software.

I'm exporting ~0,5Tb of photos / videos. There are thousands of photos with missing geolocation (checked at Google Photos) and without date after processing with gpth. From where should I start to trace reasons why there is no such metadata?

@TheLastGimbus
Copy link
Owner

@alexander-myltsev did your camera even collect it? is it visible in the app? did you change it manually? etc etc

@alexander-myltsev
Copy link

did your camera even collect it? is it visible in the app?

Both yes. There is that metadata in Google Photos.

did you change it manually? etc etc

Definitely no.

@matthewmcneill
Copy link

Just some additional info here - based mainly on researching how to use EXIFTool by Phil Harvey. Perhaps add these to the readme for now?

Discussion on Phil Harvey's site:
https://exiftool.org/forum/index.php?topic=12361.0

Pretty comprehensive summary to cope with -edited.* and json files and also options to process ALL tags in the json.
https://github.com/m1rkwood/google-photos-takeout-scripts/blob/main/README.md

M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exif Related to exif - or lack fo them in gpth.dart
Projects
None yet
Development

No branches or pull requests

5 participants