Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection timeout issues #141

Open
TheRandomLabs opened this issue Dec 13, 2020 · 5 comments
Open

Connection timeout issues #141

TheRandomLabs opened this issue Dec 13, 2020 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed info More information needed

Comments

@TheRandomLabs
Copy link
Owner

TheRandomLabs commented Dec 13, 2020

Some users seem to be experiencing timeout issues even with this mod installed. (See #94)
If you have this problem, can you make sure that your KeepAlive packet interval is set to 15 seconds? Keep in mind that the read timeout is specified in seconds, but the login timeout is specified in ticks.
If you can also ensure that a message like this: on 1.14+ Patching method: ...
occurs in the console, that would be great. The message doesn't seem to appear in the log because of some weird Forge stuff.
A reminder that the timeout options are server-sided (except for the read timeout which has some client-sided functionality). The configuration options will be less confusing in the 1.16.4 rewrite.
EDIT: In the rewrite, the configuration options are better-organised and documented.

@TheRandomLabs TheRandomLabs added info More information needed bug Something isn't working help wanted Extra attention is needed labels Dec 13, 2020
@Diversion98
Copy link

Diversion98 commented Dec 13, 2020

Hi!

Im running a server (MC Eternal 1.3.7.1) and I added the latest version of randompatches to the server (1.12.2-1.22.1.10).
There are now 3 players out of 18 that cant join because a time out.
If I delete the randompatches mod, they can just join fine.

I increased the timings as follow:
keepalive = 15
loginTimeout=360000
I:readTimeout=900000

But it just seems it gets ignored.

Also I dont get the RandomPatches ServerLoginNetHandler Transformer message in the console.

@TheRandomLabs
Copy link
Owner Author

TheRandomLabs commented Dec 13, 2020

Whoops, that message is only for 1.14+.
That's annoying; can you send me a debug.log?
Also, did the default configuration cause the same problem?

@TheRandomLabs
Copy link
Owner Author

TheRandomLabs commented Dec 31, 2020

If someone is experiencing this on 1.16.4, can they check if 2.1.0 fixes this issue (Forge/Fabric)?

@Ryorama
Copy link

Ryorama commented Jan 2, 2021

I don’t know if I should open a new issue(I just put this here as it’s an existing issue). Anyway, the error keeps occurring for me as well on 1.16.4 with the mod version being 2.1.2. I’m also using the fabric version.

@x13x54
Copy link

x13x54 commented May 19, 2021

EDIT: I traced my issue back to the login mod mentioned below. The mod has gone through many improvements since the version we were using and the timeout issue has been fixed in the latest version. If you are running this mod, update it if you see one of these error in the server console: [Server thread/INFO] [net.minecraft.network.play.ServerPlayNetHandler/]: <player> lost connection: Login timed out OR [Server thread/INFO] [net.minecraft.network.play.ServerPlayNetHandler/]: <player> lost connection: Login timeout

While going through server config today i found that a different mod called SimpleLogin has a default login timeout of 60 seconds.
Changing this value in <server>/<world>/serverconfig/simplelogin-server.toml and then doing a server restart appears to have fixed the login timeout issue that our players have occasionally suffered.

Perhaps this is one of the causes for this for some other people as well? When searching for "minecraft login mod" the simplelogin mod is all the way at the top..

Exact error message we got exactly 60 seconds after first sign of login: [18May2021 16:20:43.563] [Server thread/INFO] [net.minecraft.network.play.ServerPlayNetHandler/]: x13 lost connection: Login timed out. (I now believe this to be an error from the login mod timing out)

We have instructed players to add -Dfml.readTimeout=600 (even though forge removed it) to their java options and set their randompatches timeouts to 20 minutes before, but this had no clear effect prior to changing the simplelogin timeout value.

We're running this on an 8GB (ddr3) ram linux VPS with a openj9 java VM.
Versions:
RandomPatches 2.4.4
Minecraft 1.16.5
Forge 36.1.2
AllTheMods6 1.5.8b
SimpleLogin 1.16-0.0.0

PS: In case it's not clear to anyone, the server i have found this issue on has online-mode=false in it's server.properties and is used by a closed group of friends as opposed to a fully public online server. This might lead to the error message being different as well as this solution not applying to people who have their server configured differently.

x13x54 added a commit to x13x54/SimpleLogin that referenced this issue May 19, 2021
Fixes TheRandomLabs/RandomPatches#141 (comment)

Large modpacks can come hand-in-hand with client-side freezes lasting over a minute, causing a disconnect even if the login credentials match.
Large modpacks feature mods like RandomPatches to increase the timeouts used by minecraft and forge for this reason, and despite having this mod it seemed like TheRandomLabs/RandomPatches#141 was happening on our server as well, until i found this timeout value that exactly matches how long it takes for a player to time out on our server.
Increasing this value tenfold in `<server>/<world>/serverconfig/simplelogin-server.toml` fixed this issue for the server i am one of the operators of.
Since players should not be able to do any damage while not logged in this should not have any negative effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed info More information needed
Projects
None yet
Development

No branches or pull requests

4 participants