Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So how is this supposed to work? #57

Closed
cjurjiu opened this issue Nov 21, 2023 · 4 comments
Closed

So how is this supposed to work? #57

cjurjiu opened this issue Nov 21, 2023 · 4 comments

Comments

@cjurjiu
Copy link

cjurjiu commented Nov 21, 2023

A Next.js Top Loading Bar component made using nprogress, works with Next.js 14.

The readme describes what this (a loading bar), what's it build on top of (nprogress), and that it also works with Nextjs. It also explains various config options, although some of them would imho need some more details (e.g. crawlSpeed?)

Yet is doesn't explain how it is supposed to work. When does loading start? When should it stop?

My experience is that I installed this in my project, I see the progress bar starting when I click to navigate to a new page yet the page loads but the progress bar is still only halfway done. I also checked the network tab, no requests are happening in the background, yet the loading bar is still there -> this is weird.

So then I can't help but think: is this indented? is it not? do I need to change some setting? I don't know, the readme doesn't get into these details.

If I knew this info, I wouldn't mind making a PR where this kind of info is mentioned. Sadly I don't.

@njbmartin
Copy link

There's a bug #56 caused by Next 14.0.3

@cjurjiu
Copy link
Author

cjurjiu commented Nov 22, 2023

Thanks @njbmartin, downgrading to 14.0.2 did the trick for me.

But my point is still valid I would say: the docs feel written for someone that already knows how the library works. Take for instance showSpinner -> where is this spinner shown? I can't see any different with this option on or off.

What does crawl mean? Docs say "auto incrementing behavior for the TopLoader.". Does it refer to the integer amount added to the width of the topbar on each tick/update? if yes, then crawl is a weird name.

etc.

@nunesunil
Copy link

Fixed by vercel/next.js#58861 and released in v14.0.4-canary.37.

@huboh
Copy link

huboh commented Dec 12, 2023

Yeah, installed the top loader yesterday and was confused why it was still animating when page has finish loading. I'm running next v14.0.3

@TheSGJ TheSGJ closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants