From 061a90f1dd457a1cc9efb760e86b68fda49bab9e Mon Sep 17 00:00:00 2001 From: Tom Pallister Date: Tue, 15 May 2018 18:29:35 +0100 Subject: [PATCH] #349 default to no load balancer so that in load balaner house we dont always rebuild the loadbalancer infrastructure because the load balancer options type is null (#358) --- src/Ocelot/Configuration/LoadBalancerOptions.cs | 4 +++- .../LoadBalancer/LoadBalancerOptionsTests.cs | 17 +++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 test/Ocelot.UnitTests/LoadBalancer/LoadBalancerOptionsTests.cs diff --git a/src/Ocelot/Configuration/LoadBalancerOptions.cs b/src/Ocelot/Configuration/LoadBalancerOptions.cs index fd5b8b354..08dc3b87e 100644 --- a/src/Ocelot/Configuration/LoadBalancerOptions.cs +++ b/src/Ocelot/Configuration/LoadBalancerOptions.cs @@ -1,10 +1,12 @@ +using Ocelot.LoadBalancer.LoadBalancers; + namespace Ocelot.Configuration { public class LoadBalancerOptions { public LoadBalancerOptions(string type, string key, int expiryInMs) { - Type = type; + Type = type ?? nameof(NoLoadBalancer); Key = key; ExpiryInMs = expiryInMs; } diff --git a/test/Ocelot.UnitTests/LoadBalancer/LoadBalancerOptionsTests.cs b/test/Ocelot.UnitTests/LoadBalancer/LoadBalancerOptionsTests.cs new file mode 100644 index 000000000..6486b83f3 --- /dev/null +++ b/test/Ocelot.UnitTests/LoadBalancer/LoadBalancerOptionsTests.cs @@ -0,0 +1,17 @@ +using Ocelot.Configuration; +using Ocelot.LoadBalancer.LoadBalancers; +using Shouldly; +using Xunit; + +namespace Ocelot.UnitTests.LoadBalancer +{ + public class LoadBalancerOptionsTests + { + [Fact] + public void should_default_to_no_load_balancer() + { + var options = new LoadBalancerOptionsBuilder().Build(); + options.Type.ShouldBe(nameof(NoLoadBalancer)); + } + } +}