TW5.com Document Style and Class Prefix

[kookma]

In https://tiddlywiki.com/#%24%3A%2F_tw5.com-styles

last part we have

}/* WikiText rules */.multi-columns,
.fourcolumns {
	display: block;
	column-count: 4;
	column-gap: 1em;
	-moz-column-count: 4;
	-moz-column-gap: 1em;
	-webkit-column-count: 4;
	-webkit-column-gap: 1em;
}@media (max-width: 960px) {
	.multi-columns {
		column-count: 2;
	}
}

but the convention is to prefix these with tc-.

@pmario
I think these styles are maintained by you! Please take a look.

[pmario]

.fourcolumns is used as a documentation example at: https://tiddlywiki.com/#Formatting%20List%20Results%20as%20Tables%20with%20CSS%20-%20Specified%20Columns%20Methods

So it's a "user" defined class. We should not promote tc-prefixed classes in our examples, because users should not use them with copy / paste. They should define their own conventions.

.multi-columns technically is a user definition too. So that's why they do not have a tc- prefix at the moment.

@Jermolene -- I'm not sure, if we should change that.

[kookma]

Thank you for clarification.

I brought up this point because everything else at https://tiddlywiki.com/#%24%3A%2F_tw5.com-styles is prefixed with tc-. I was thinking, if .multi-columns is a user-defined class, perhaps we could create a separate tiddler for all user-defined classes.

[pmario]

hmm, Somehow all doc-tiddlers are user-created -- But they are also special because they belong to tw-com.

---

I wanted to create a "download doc-tools button" somewhere, to make it easier to save and import doc-macros and all related "boiler-plate" tiddlers into my own wikilabs documentation editions.

But I'm still not sure, where I should add this button :/

[Jermolene]

I think it makes sense to add the tc- prefix, keeping the old definition for backwards compatibility.

I wanted to create a "download doc-tools button" somewhere, to make it easier to save and import doc-macros and all related "boiler-plate" tiddlers into my own wikilabs documentation editions.

I think we've discussed elsewhere that it might make more sense to pull the docs macros out into a plugin.

[kookma]

Thank you for clarification.
Please let me know if I should submit a PR or @pmario will take the responsibility.

[pmario]

Please let me know if I should submit a PR ...

• It would be nice, if you could create a PR for tc-multi-columns ... in the stylesheet tiddler

• A second PR could be created, where it is used in the docs.

[kookma]

@Jermolene
To correct this, I assume to I should submit PR to master branch not tw5.ocm?

[pmario]

tw5-com should be good enough - It is a documentation change and we should be able to merge it at any time

[kookma]

@pmario
Done. See #8276