Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error when connecting PipeLoader SDXL to CR Load LoRA #36

Open
mattymatty opened this issue Aug 27, 2023 · 7 comments
Open

New error when connecting PipeLoader SDXL to CR Load LoRA #36

mattymatty opened this issue Aug 27, 2023 · 7 comments

Comments

@mattymatty
Copy link

mattymatty commented Aug 27, 2023

CR Load LoRA use to work with the PipeLoader SDXL but now it doesn't. Is there any help?

@TinyTerra
Copy link
Owner

Do you have an example workflow? and the latest version of ttN and comfyroll?
I've tested in and it seems to work with the most recent push of ttN
(there were some changes to pipeline in earlier versions that have been reverted that could be breaking it)

@mattymatty
Copy link
Author

mattymatty commented Aug 29, 2023

I get this error: AttributeError: 'dict' object has no attribute 'cond_stage_model'

Workflow

{
  "last_node_id": 214,
  "last_link_id": 519,
  "nodes": [
    {
      "id": 196,
      "type": "Save_as_webp",
      "pos": [
        1455,
        271
      ],
      "size": {
        "0": 459.8302001953125,
        "1": 436.8377685546875
      },
      "flags": {},
      "order": 3,
      "mode": 0,
      "inputs": [
        {
          "name": "images",
          "type": "IMAGE",
          "link": 483
        }
      ],
      "properties": {
        "Node name for S&R": "Save_as_webp"
      },
      "widgets_values": [
        "ComfyUI",
        "lossy",
        80
      ]
    },
    {
      "id": 193,
      "type": "ttN pipeKSamplerSDXL",
      "pos": [
        934,
        248
      ],
      "size": {
        "0": 383.4972839355469,
        "1": 466
      },
      "flags": {},
      "order": 2,
      "mode": 0,
      "inputs": [
        {
          "name": "sdxl_pipe",
          "type": "PIPE_LINE_SDXL",
          "link": 477
        },
        {
          "name": "optional_model",
          "type": "MODEL",
          "link": 487
        },
        {
          "name": "optional_positive",
          "type": "CONDITIONING",
          "link": null
        },
        {
          "name": "optional_negative",
          "type": "CONDITIONING",
          "link": null
        },
        {
          "name": "optional_vae",
          "type": "VAE",
          "link": null
        },
        {
          "name": "optional_refiner_model",
          "type": "MODEL",
          "link": null
        },
        {
          "name": "optional_refiner_positive",
          "type": "CONDITIONING",
          "link": null
        },
        {
          "name": "optional_refiner_negative",
          "type": "CONDITIONING",
          "link": null
        },
        {
          "name": "optional_refiner_vae",
          "type": "VAE",
          "link": null
        },
        {
          "name": "optional_latent",
          "type": "LATENT",
          "link": null
        },
        {
          "name": "optional_clip",
          "type": "CLIP",
          "link": 488
        },
        {
          "name": "seed",
          "type": "INT",
          "link": null,
          "widget": {
            "name": "seed",
            "config": [
              "INT",
              {
                "default": 0,
                "min": 0,
                "max": 18446744073709552000
              }
            ]
          }
        }
      ],
      "outputs": [
        {
          "name": "sdxl_pipe",
          "type": "PIPE_LINE_SDXL",
          "links": null,
          "shape": 3
        },
        {
          "name": "model",
          "type": "MODEL",
          "links": null,
          "shape": 3
        },
        {
          "name": "positive",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "negative",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "vae",
          "type": "VAE",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_model",
          "type": "MODEL",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_positive",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_negative",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_vae",
          "type": "VAE",
          "links": null,
          "shape": 3
        },
        {
          "name": "latent",
          "type": "LATENT",
          "links": null,
          "shape": 3
        },
        {
          "name": "clip",
          "type": "CLIP",
          "links": null,
          "shape": 3
        },
        {
          "name": "image",
          "type": "IMAGE",
          "links": [
            483
          ],
          "shape": 3,
          "slot_index": 11
        },
        {
          "name": "seed",
          "type": "INT",
          "links": null,
          "shape": 3
        }
      ],
      "properties": {
        "Node name for S&R": "ttN pipeKSamplerSDXL",
        "ttNnodeVersion": "1.0.0"
      },
      "widgets_values": [
        "None",
        2,
        "disabled",
        "Sample",
        20,
        5,
        8,
        "euler",
        "normal",
        "Preview",
        "ComfyUI",
        609453472443986,
        "randomize"
      ],
      "color": "#323",
      "bgcolor": "#535"
    },
    {
      "id": 192,
      "type": "ttN pipeLoaderSDXL",
      "pos": [
        6,
        255
      ],
      "size": {
        "0": 480,
        "1": 850
      },
      "flags": {},
      "order": 0,
      "mode": 0,
      "outputs": [
        {
          "name": "sdxl_pipe",
          "type": "PIPE_LINE_SDXL",
          "links": [
            477
          ],
          "shape": 3,
          "slot_index": 0
        },
        {
          "name": "model",
          "type": "MODEL",
          "links": [
            486
          ],
          "shape": 3,
          "slot_index": 1
        },
        {
          "name": "positive",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "negative",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "vae",
          "type": "VAE",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_model",
          "type": "MODEL",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_positive",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_negative",
          "type": "CONDITIONING",
          "links": null,
          "shape": 3
        },
        {
          "name": "refiner_vae",
          "type": "VAE",
          "links": null,
          "shape": 3
        },
        {
          "name": "latent",
          "type": "LATENT",
          "links": null,
          "shape": 3
        },
        {
          "name": "clip",
          "type": "CLIP",
          "links": [
            485
          ],
          "shape": 3,
          "slot_index": 10
        },
        {
          "name": "seed",
          "type": "INT",
          "links": null,
          "shape": 3
        }
      ],
      "properties": {
        "Node name for S&R": "ttN pipeLoaderSDXL",
        "ttNnodeVersion": "1.0.0"
      },
      "widgets_values": [
        "MODELS_SDXL\\sd_xl_base_1.0.safetensors",
        "Baked VAE",
        "None",
        1,
        1,
        "None",
        1,
        1,
        "MODELS_SDXL\\sd_xl_refiner_1.0.safetensors",
        "Baked VAE",
        "None",
        1,
        1,
        "None",
        1,
        1,
        -2,
        "evening sunset scenery blue sky nature, glass bottle with a galaxy in it",
        "none",
        "comfy",
        "text, watermark",
        "none",
        "comfy",
        1024,
        1024,
        1,
        721897303308196,
        "fixed"
      ],
      "color": "#222",
      "bgcolor": "#000"
    },
    {
      "id": 197,
      "type": "LoraLoader",
      "pos": [
        546,
        416
      ],
      "size": {
        "0": 315,
        "1": 126
      },
      "flags": {},
      "order": 1,
      "mode": 0,
      "inputs": [
        {
          "name": "model",
          "type": "MODEL",
          "link": 486
        },
        {
          "name": "clip",
          "type": "CLIP",
          "link": 485
        }
      ],
      "outputs": [
        {
          "name": "MODEL",
          "type": "MODEL",
          "links": [
            487
          ],
          "shape": 3,
          "slot_index": 0
        },
        {
          "name": "CLIP",
          "type": "CLIP",
          "links": [
            488
          ],
          "shape": 3,
          "slot_index": 1
        }
      ],
      "properties": {
        "Node name for S&R": "LoraLoader"
      },
      "widgets_values": [
        "SDXL\\SDXL_Black_Sa_May.safetensors",
        1,
        1
      ]
    }
  ],
  "links": [
    [
      477,
      192,
      0,
      193,
      0,
      "PIPE_LINE_SDXL"
    ],
    [
      483,
      193,
      11,
      196,
      0,
      "IMAGE"
    ],
    [
      485,
      192,
      10,
      197,
      1,
      "CLIP"
    ],
    [
      486,
      192,
      1,
      197,
      0,
      "MODEL"
    ],
    [
      487,
      197,
      0,
      193,
      1,
      "MODEL"
    ],
    [
      488,
      197,
      1,
      193,
      10,
      "CLIP"
    ]
  ],
  "groups": [],
  "config": {},
  "extra": {},
  "version": 0.4
}

@TinyTerra
Copy link
Owner

Okay, thanks for that.
Didn't realise you meant the SDXL loader - the clip line was actually outputting the latent... fixed in 351d36c

@mattymatty
Copy link
Author

thanks

@mattymatty
Copy link
Author

I just tried using a lora and it still does not work

@mattymatty mattymatty reopened this Aug 30, 2023
@mattymatty mattymatty changed the title New error when connecting PipeLoader to CR Load LoRA New error when connecting PipeLoader SDXL to CR Load LoRA Aug 30, 2023
@Suzie1
Copy link

Suzie1 commented Aug 31, 2023

Hi, I have tested this and it works ok for me. Have you checked your ComfyUI is up to date? I recommend using the bat file update. Please DM me on AI Revolution if this continues to be a problem. Suzie

@mattymatty
Copy link
Author

can you share the workflow? maybe I am doing it wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants