From e00f8f37b19d4752f2c81eed3d1389a72ea723e7 Mon Sep 17 00:00:00 2001 From: Thomas Newton Date: Fri, 4 Oct 2024 20:19:55 +0100 Subject: [PATCH] Adjust some parameters on the generic tests --- cpp/src/arrow/filesystem/azurefs_test.cc | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/cpp/src/arrow/filesystem/azurefs_test.cc b/cpp/src/arrow/filesystem/azurefs_test.cc index c12cb90da7e07..fdae7703ff19f 100644 --- a/cpp/src/arrow/filesystem/azurefs_test.cc +++ b/cpp/src/arrow/filesystem/azurefs_test.cc @@ -364,9 +364,9 @@ class TestGeneric : public ::testing::Test, public GenericFileSystemTest { std::shared_ptr GetEmptyFileSystem() override { return fs_; } bool have_implicit_directories() const override { return true; } - bool allow_write_file_over_dir() const override { return true; } - bool allow_read_dir_as_file() const override { return true; } - bool allow_move_dir() const override { return false; } + bool allow_write_file_over_dir() const override { return false; } + bool allow_read_dir_as_file() const override { return false; } + bool allow_move_dir() const override { return true; } bool allow_move_file() const override { return true; } bool allow_append_to_file() const override { return true; } bool have_directory_mtimes() const override { return true; } @@ -404,8 +404,12 @@ class TestAzuriteGeneric : public TestGeneric { } protected: - // Azurite doesn't support moving files over containers. + // Azurite doesn't block writing files over directories. + bool allow_write_file_over_dir() const override { return true; } + // Azurite doesn't support moving files. bool allow_move_file() const override { return false; } + // Azurite doesn't support moving directories. + bool allow_move_dir() const override { return false; } // Azurite doesn't support directory mtime. bool have_directory_mtimes() const override { return false; } // DeleteDir() doesn't work with Azurite on macOS @@ -426,8 +430,12 @@ class TestAzureFlatNSGeneric : public TestGeneric { } protected: - // Flat namespace account doesn't support moving files over containers. + // Flat namespace account doesn't block writing files over directories. + bool allow_write_file_over_dir() const override { return true; } + // Flat namespace account doesn't support moving files. bool allow_move_file() const override { return false; } + // Flat namespace account doesn't support moving directories. + bool allow_move_dir() const override { return false; } // Flat namespace account doesn't support directory mtime. bool have_directory_mtimes() const override { return false; } };