From a9747e43e4ac173ac1ef0f49fc812cb2991c16bf Mon Sep 17 00:00:00 2001
From: Justin K <justin.k@justplayer.de>
Date: Thu, 4 Jul 2024 11:13:07 +0200
Subject: [PATCH] fix: use official color:lerp implementation if possible (#56)

* fix: use official color:lerp implementation

* fix: add the old implementation back for backwards compatibility with deprecation warning

* fix: only show deprecation warning once
---
 lua/pixelui/core/cl_color.lua | 34 ++++++++++++++++++++++++++--------
 1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/lua/pixelui/core/cl_color.lua b/lua/pixelui/core/cl_color.lua
index 4fdb710..b0d1b35 100644
--- a/lua/pixelui/core/cl_color.lua
+++ b/lua/pixelui/core/cl_color.lua
@@ -142,7 +142,7 @@ do
 end
 
 function PIXEL.LerpColor(t, from, to)
-    return createColor(from.r, from.g, from.b, from.a):Lerp(t, to)
+    return createColor(from.r, from.g, from.b, from.a):Lerp(to, t)
 end
 
 function PIXEL.IsColorEqualTo(from, to)
@@ -161,11 +161,29 @@ function colorMeta:Offset(offset)
     return self
 end
 
-local lerp = Lerp
-function colorMeta:Lerp(t, to)
-    self.r = lerp(t, self.r, to.r)
-    self.g = lerp(t, self.g, to.g)
-    self.b = lerp(t, self.b, to.b)
-    self.a = lerp(t, self.a, to.a)
-    return self
+-- Combatibility for versions before 2024.06.28
+if not colorMeta.Lerp then
+    local lerp = Lerp
+    local isColor = IsColor
+    local deprecation_warning_shown = false
+    function colorMeta:Lerp(target, fraction)
+        if isColor(fraction) then
+            -- Don't break addons using this based on Pixel UI for now.
+            local rememberFraction = fraction
+            fraction = target
+            target = rememberFraction
+
+            if not deprecation_warning_shown then
+                deprecation_warning_shown = true
+                -- Scream at them at least once though, should be fine to keep this backwards compatibility until the update. 
+                ErrorNoHaltWithStack("Deprecated PIXEL-UI Color:Lerp(fraction, target) is used.")
+            end
+        end
+
+        self.r = lerp(fraction, self.r, target.r)
+        self.g = lerp(fraction, self.g, target.g)
+        self.b = lerp(fraction, self.b, target.b)
+        self.a = lerp(fraction, self.a, target.a)
+        return self
+    end
 end