Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted placeholder. #109

Closed
yiyoperez opened this issue Jun 8, 2024 · 5 comments
Closed

Formatted placeholder. #109

yiyoperez opened this issue Jun 8, 2024 · 5 comments
Labels
duplicate This issue or pull request already exists wontfix This will not be worked on

Comments

@yiyoperez
Copy link

This plugin currently doesn't accept formatted values to create the leaderboards.

Creating other display types such as top_name, top_value etc... a formatted one (like value_money, value_time) will help players creating leaderboards from raw placeholders and then formatting it into hours format or money format.

The value could also just be "value_formatted" and use formatters section to choose from time, money or any other formatting.

@HSGamer
Copy link
Member

HSGamer commented Jun 8, 2024

Use Formatter expansion

@HSGamer HSGamer closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2024
@HSGamer
Copy link
Member

HSGamer commented Jun 8, 2024

And no, plugins must provide placeholders that give raw values.
If your plugin doesn't have one, ask the author to add that.

@yiyoperez
Copy link
Author

Use Formatter expansion

The point is to do it locally, no placeholderapi extension needed.

And no, plugins must provide placeholders that give raw values. If the plugin doesn't have one, ask the author to add that.

Seems like you misunderstood the suggestion, Im not asking you to create raw values I want to use them to create a leaderboard and then format it by YOU creating a placeholder to format de previously USED raw placeholder/value to create the top.

@HSGamer
Copy link
Member

HSGamer commented Jun 8, 2024

I don't want to waste time maintaining parts that others did perfectly.
So, I answered it in both ways:

  • If you want to format the top value to some weird formats like short money, time format, etc., then use Formatter expansion. You already have to install PlaceholderAPI to use this plugin anyways, why not a single expansion that did exactly what you need but not limited only to Topper.
  • If you want Topper to support formatted placeholders from other plugins when creating leaderboards, then no. Plugins must provide placeholders that give raw values (only numbers and the decimal separator, no weird format). If one plugin doesn't have one, ask its author to add it.

@HSGamer HSGamer added wontfix This will not be worked on duplicate This issue or pull request already exists labels Jun 8, 2024
@HSGamer
Copy link
Member

HSGamer commented Jun 8, 2024

Duplicated to #93

@HSGamer HSGamer pinned this issue Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants