fix(engineio/ws): add read_buffer_size option and set default to 4KiB #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totodore
added
A-socketioxide
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Totodore
force-pushed
the
fix-ws-mem-usage
branch
from
5364304 to
e87dfbe
Compare
Totodore
force-pushed
the
fix-ws-mem-usage
branch
7 times, most recently
from
a338368 to
5e578d6
Compare
Totodore
force-pushed
the
fix-ws-mem-usage
branch
from
5e578d6 to
8f67130
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With recent changes to tokio-tungstenite, the memory usage is a lot heavier. See related issue #448.
Solution
read_buffer_sizeto 4KiB (the same value that in the previous tokio-tungstenite versions) and expose an option in socketioxide and engineioxide to manually change this value.Bytesbinary buffer for the partial binary packets. Otherwise the buffer is saved and the websocket read buffer needs to grow as it still has a living data bound to it.