[BUG] [Indestructible] VM Abort on Changemap

[mattbratt11]

I used Indestructible 0.2.3 after Guns Bonsai 0.9.0 in load order for GZDoom 4.8.2.
The Crash happened at the start of the following map after exiting from the previous map.
Every time I use the changemap CCMD onto any map, this crash is also guaranteed.

[ToxicFrog]

What other mods do you have loaded? The error implies that it's properly finding the lives item on level start, but on the next tic it's been removed from the player's inventory. I can't reproduce it here.

[mattbratt11]

What other mods do you have loaded? The error implies that it's properly finding the lives item on level start, but on the next tic it's been removed from the player's inventory. I can't reproduce it here.

I did not use any other mod but Tooltip, Guns Bonsai, and Indestructible in the load order.

[ToxicFrog]

It looks like you at least have Zabor installed as well; what else, if anything?

[mattbratt11]

I used 2 mods from m8f's Doctor's Bag at the very end of the load order.
And just in case, I have my load order list for ZDL posted here in text if you want to see it.

• libtooltipmenu-0.2.1.pk3
• GunsBonsai-0.9.1.pk3
• Indestructible-0.2.3.pk3
• mod-menu-v1.1.0.pk3
• mod-compatibility-checklist-v1.0.2.pk3
• zabor-v1.1.0.pk3

The bug still happened. And to prove it, I've uploaded both crashreport.txt and a screenshot for full proof.

crashreport.txt
after almost a year, this bug even happened on stable GZDoom v4.10.0 and onwards.
I think it has something to do with A_Log and/or A_Print or something like that.

[mattbratt11]

In case I couldn't find a PM to contact ToxicFrog, I might as well post again if that's okay.
It's been a long time since the last post, but no one replied.
Any help?

[ToxicFrog]

Sorry I lost track of this, but I also still can't figure out how to trigger it on my end, which makes fixing it kind of tricky.

The stack trace implies that it's crashing when it goes to display the "you have [n] new lives" message on level entry. Specifically, that when it does that, the item that holds the extra life counter still exists but is no longer held by the player.

I could add a check for this that gracefully self-destructs it, but this would likely just result in situations where Indestructable silently stops working instead of crashing outright, and I'd rather get to the bottom of this and fix it properly.

I'm also suspicious of the [ERROR] Mod Compatibility Checklist: PlayerSpawned: Player has no weapons message. I'd normally only expect to see that if you were playing with Universal Pistol Start or something else that empties the player's inventory on level transition. I suspect that whatever is causing that is going to turn out to be whatever's triggering this bug in Indestructable.

So, more information gathering:

• does this still happen with the most recent versions of Indestructable and Gun Bonsai?
• does it happen if you remove Gun Bonsai?
• does it happen if you remove every other mod except Indestructable?
• does it happen on every level change, or only some?
• if the latter, can you trigger it reliably (by entering a certain level, carrying a certain weapon, using certain settings, etc) or is it seemingly random?

[mattbratt11]

I've played the recent version of GZDoom (v4.11.3) using Indestructible and no other mod.
The bug still happened on every level change no matter what I did, including a regular exit as usual.
I triggered it by exiting the first map, transitioning to enter the next map, thus failing to enter it by a guaranteed crash.
Maybe it has something to do with the indestructable.ZSC file in lines 36, 52, and 64.
BTW, is there a reason you misspelled Indestructible?

[ToxicFrog]

No reason, I just blithely assumed it ended with -able like most things do. Apparently it does not! How annoying.

Anyways. I still can't reproduce this; please (a) make sure you are using the latest version of the mod and then (b) post the stack trace.